Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #32250

Merged
merged 20 commits into from
May 9, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 4, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20230508.4
  • Date Produced: May 8, 2023 8:45:38 PM UTC
  • Commit: b1329633572d124fe43f7d58bb113f59f886e80b
  • Branch: refs/heads/main

…0504.1

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23254.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels May 4, 2023
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 4, 2023

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@jeffschwMSFT
Copy link
Member

@MihaZupan @karelz can y'all take a look at this dependency flow failures? Looks related to dotnet/runtime#85686

System.TypeLoadException : Could not load type 'System.Buffers.IndexOfAnyValues`1' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
 at Microsoft.Net.Http.Headers.HttpRuleParser.GetTokenLength(StringSegment input, Int32 startIndex)
   at Microsoft.Net.Http.Headers.MediaTypeHeaderValue.GetMediaTypeExpressionLength(StringSegment input, Int32 startIndex, StringSegment& mediaType)
   at Microsoft.Net.Http.Headers.MediaTypeHeaderValue.GetMediaTypeLength(StringSegment input, Int32 startIndex, MediaTypeHeaderValue& parsedValue)
   at Microsoft.Net.Http.Headers.GenericHeaderParser`1.GetParsedValueLength(StringSegment value, Int32 startIndex, T& parsedValue)
   at Microsoft.Net.Http.Headers.BaseHeaderParser`1.TryParseValue(StringSegment value, Int32& index, T& parsedValue)
   at Microsoft.Net.Http.Headers.HttpHeaderParser`1.TryParseValues(IList`1 values, Boolean strict, IList`1& parsedValues)
   at Microsoft.AspNetCore.Http.HeaderDictionaryTypeExtensions.<>c.<.cctor>b__14_9(IList`1 value)
   at Microsoft.AspNetCore.Http.HeaderDictionaryTypeExtensions.GetList[T](StringValues values)
   at Microsoft.AspNetCore.Http.Headers.RequestHeaders.get_Accept()
   at Microsoft.AspNetCore.Watch.BrowserRefresh.BrowserRefreshMiddleware.IsBrowserDocumentRequest(HttpContext context) in /_/src/BuiltInTools/BrowserRefresh/BrowserRefreshMiddleware.cs:line 83
   at Microsoft.AspNetCore.Watch.BrowserRefresh.BrowserRefreshMiddleware.InvokeAsync(HttpContext context) in /_/src/BuiltInTools/BrowserRefresh/BrowserRefreshMiddleware.cs:line 27
   at Microsoft.AspNetCore.Watch.BrowserRefresh.BrowserRefreshMiddlewareTest.InvokeAsync_AddsScriptToThePage() in /_/src/Tests/Microsoft.AspNetCore.Watch.BrowserRefresh.Tests/BrowserRefreshMiddlewareTest.cs:line 243
--- End of stack trace from previous location ---

@MihaZupan
Copy link
Member

The rename was both a source and binary breaking change.
In this case, the runtime has already been updated, but aspnetcore hasn't.

dotnet/aspnetcore#48067 and dotnet/aspnetcore#48014 will have to be merged to unblock this.

@lewing
Copy link
Member

lewing commented May 4, 2023

waiting on dotnet/aspnetcore#48014 now which has the same errors dotnet/installer#16318 sees in sourcebuild

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 4, 2023

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…0504.7

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23254.7
…0505.1

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.1
@lewing lewing closed this May 5, 2023
@lewing lewing reopened this May 5, 2023
@jeffschwMSFT
Copy link
Member

@MihaZupan looks like the upstream changes are all merged. what is the next step?

…0505.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.2
@MihaZupan
Copy link
Member

From what I can see aspnetcore update was merged with #32287.
The fact that PR did not encounter the same issue means the test in this repo isn't actually using the latest local version.
It appears that Microsoft.AspNetCore.Watch.BrowserRefresh.Tests are picking up the updated runtime target, but not the updated aspnetcore one -- who could help with that?

@lewing
Copy link
Member

lewing commented May 5, 2023

cc @dotnet/aspnet-blazor-eng

@lewing
Copy link
Member

lewing commented May 5, 2023

@dotnet/domestic-cat what is the right way to make sure the test picks up the correct version (from Versions.props) of aspnetcore?

cc @eerhardt

@BrennanConroy
Copy link
Member

Runtime does some trickery here:

<!-- Update KnownFrameworkReferences to target the right version of the runtime -->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'
and $(MicrosoftNETCoreAppRefPackageVersion.StartsWith('$(_TargetFrameworkVersionWithoutV)'))
and '$(MSBuildProjectName)' != 'toolset-tasks'">
<FrameworkReference
Update="Microsoft.NETCore.App"
TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)" />
</ItemGroup>

Does a similar thing need to be done for ASP.NET?

dotnet-maestro bot added 10 commits May 5, 2023 21:57
…0505.4

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.4
…0505.6

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.6
…0505.7

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.7
…0505.8

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23255.8
…0506.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23256.2
…0506.3

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23256.3
…0506.4

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23256.4
…0507.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23257.2
…0507.3

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23257.3
…0508.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23258.2
@jeffschwMSFT
Copy link
Member

who has the next step on this dependency flow? The same missing type failures remain @MihaZupan.

…0508.3

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23258.3
@jeffschwMSFT
Copy link
Member

@karelz @MihaZupan is there a path forward by backing out the breacking change and staging it in such a way to get this code flow unblocked?

@eerhardt
Copy link
Member

eerhardt commented May 8, 2023

@BrennanConroy (who is currently on build-ops) - can you fix these tests to use the current version of asp.net and not the one coming from the SDK?

@BrennanConroy
Copy link
Member

If I knew how I would have done it already.

…0508.4

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.5.23253.15 -> To Version 8.0.0-preview.5.23258.4
@MihaZupan
Copy link
Member

@dotnet/dnceng This repository has one test project Microsoft.AspNetCore.Watch.BrowserRefresh.Tests which appears to be consuming the latest version of runtime (which is being updated by this PR), but an older version of aspnetcore.
Can someone please assist in configuring this project to target the latest version of aspnetcore from this repo as well, like it already does for runtime?

@joeloff
Copy link
Member

joeloff commented May 8, 2023

I noticed that https://github.com/dotnet/sdk/blob/f2f1006505b1397bb2042d5b720bca6fdb2293b4/src/Tests/Microsoft.AspNetCore.Watch.BrowserRefresh.Tests/Microsoft.AspNetCore.Watch.BrowserRefresh.Tests.csproj#LL12C5-L12C5

References a project that is targeting net6.0

We generally have runtimes going back to 1.0 installed locally in the build for various tests.

We typically install the SDK that comes from global.json, then overlay the new SDK we built on top of that. We are updating the runtime to a different version, but not asp.net/desktop from what I can tell.

eng/Versions.props Outdated Show resolved Hide resolved
@nagilson nagilson enabled auto-merge May 8, 2023 23:53
@nagilson nagilson merged commit 489ba47 into main May 9, 2023
@nagilson nagilson deleted the darc-main-440caf43-059a-43fc-ba7d-83af25e8c08a branch May 9, 2023 01:19
@lewing
Copy link
Member

lewing commented May 9, 2023

thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants