Skip to content

Commit

Permalink
fix(iscsi): only rely on socket activiation
Browse files Browse the repository at this point in the history
Only rely on socket activation. This speeds up in case iscsi isn't used
and also prevents failures, where iscsiuio stopping somehow disables
iscsi.
  • Loading branch information
haraldh committed Apr 26, 2021
1 parent 5eb7361 commit 0eb87d7
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions modules.d/95iscsi/module-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -235,28 +235,30 @@ install() {
$SYSTEMCTL -q --root "$initdir" enable "$i"
done

for i in \
iscsid.service \
iscsiuio.service; do
$SYSTEMCTL -q --root "$initdir" add-wants basic.target "$i"
done

# Make sure iscsid is started after dracut-cmdline and ready for the initqueue
mkdir -p "${initdir}/$systemdsystemunitdir/iscsid.service.d"
(
echo "[Unit]"
echo "After=dracut-cmdline.service"
echo "Before=dracut-initqueue.service"
echo "DefaultDependencies=no"
echo "Conflicts=shutdown.target"
echo "Before=shutdown.target"
) > "${initdir}/$systemdsystemunitdir/iscsid.service.d/dracut.conf"

# The iscsi deamon does not need to wait for any storage inside initrd
mkdir -p "${initdir}/$systemdsystemunitdir/iscsid.socket.d"
(
echo "[Unit]"
echo "DefaultDependencies=no"
echo "Conflicts=shutdown.target"
echo "Before=shutdown.target sockets.target"
) > "${initdir}/$systemdsystemunitdir/iscsid.socket.d/dracut.conf"

mkdir -p "${initdir}/$systemdsystemunitdir/iscsiuio.service.d"
(
echo "[Unit]"
echo "DefaultDependencies=no"
echo "Conflicts=shutdown.target"
echo "Before=shutdown.target"
) > "${initdir}/$systemdsystemunitdir/iscsiuio.service.d/dracut.conf"

mkdir -p "${initdir}/$systemdsystemunitdir/iscsiuio.socket.d"
(
echo "[Unit]"
Expand Down

0 comments on commit 0eb87d7

Please sign in to comment.