Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemd-resolved): add systemd-resolve user #1657

Closed

Conversation

Cornelicorn
Copy link
Contributor

@Cornelicorn Cornelicorn commented Nov 28, 2021

This pull request adds the systemd-resolve user to initramfs when using the systemd-resolved module.

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #1656

@github-actions github-actions bot added the modules Issue tracker for all modules label Nov 28, 2021
@johannbg
Copy link
Collaborator

johannbg commented Nov 28, 2021

@Cornelicorn hmm we dont parse/grep and or otherwise use users from /etc/passwd anymore anyways something must have changed in systemd upstream ( like systemd finally splitting all their users into seperated sysusers files, which then requires fixes in more places since probably more users are missing ), all the systemd users should currently be provided via systemd-sysusers module, which this module is dependent upon.

If systemd upstream has done the right thing ( by splitting it's users into seperated sysuser files ) then we need to try to included that sd-resolve sysuser file from the underlying OS probably with a fallback on our own include sd-resolve sysuser file if the sysuser file is not found.

That fix requires adding "$sysusers"/systemd-resolve.conf in the install() section of the module and "$sysusersconfdir"/systemd-resolve.conf in the hostonly section of the install() section and we probably should be adding that sysuser file to the module as well.

@Cornelicorn
Copy link
Contributor Author

Superseeded by #1658

@johannbg
Copy link
Collaborator

Somewhat permature closure since we still need to include the new systemd-resolve.conf file otherwise this will just break again with the next sd release

@Cornelicorn
Copy link
Contributor Author

Somewhat permature closure since we still need to include the new systemd-resolve.conf file otherwise this will just break again with the next sd release

Ah right, forgot about the change in systemd sysuser configs. But maybe this should be tackled in a new PR together with all other sysuser configs.

@johannbg
Copy link
Collaborator

Agreed

Cornelicorn added a commit to Cornelicorn/dracut that referenced this pull request Dec 1, 2021
johannbg pushed a commit that referenced this pull request Dec 10, 2021
@Cornelicorn Cornelicorn deleted the systemd-resolve-user branch December 10, 2021 13:12
aafeijoo-suse pushed a commit to aafeijoo-suse/dracut that referenced this pull request Feb 21, 2022
Fixes the regression introduced by systemd/systemd#20056
As discussed in dracutdevs#1656 and dracutdevs#1657

(cherry picked from commit fec93bb)
aafeijoo-suse pushed a commit to aafeijoo-suse/dracut that referenced this pull request Mar 10, 2022
Fixes the regression introduced by systemd/systemd#20056
As discussed in dracutdevs#1656 and dracutdevs#1657

(cherry picked from commit fec93bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemd-resolve user missing
2 participants