Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmsquash-live): handle relative pathspec #2253

Closed
wants to merge 1 commit into from

Conversation

LaszloGombos
Copy link
Collaborator

@LaszloGombos LaszloGombos commented Mar 1, 2023

This change is required to make the following canonical example work that is mentioned in the documentation:

rd.live.overlay=/dev/sdb1:persistent-overlay.img

This example has been in the dracut documentation since 2015.

At the same time, improve the documentation with a more specific example.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #579 (partially)

CC @FGrose @Conan-Kudo @fabiand

@github-actions github-actions bot added dmsquash-live Issues related to the dmsquash-live module modules Issue tracker for all modules labels Mar 1, 2023
Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required to make the following canonical example work that is mentioned in the documentation

Are we sure that the example in the man page (pathspec not starting with / ) is correct?

If the answer is yes, wouldn't it be easier to just fix when pathspec is assigned and doesn't start with / , to avoid the "//" case?

@LaszloGombos
Copy link
Collaborator Author

LaszloGombos commented Mar 6, 2023

Are we sure that the example in the man page (pathspec not starting with / ) is correct?

I think the example in the documentation can be improved. I added the improvement in the doc to this PR as well.

Regardless this example has been in the documentation for 7 years, and maintaining compatibility with this example seems to be simple enough.

If the answer is yes, wouldn't it be easier to just fix when pathspec is assigned and doesn't start with / , to avoid the "//" case?

Thanks for this, great catch. I made the change.

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that the example in the man page (pathspec not starting with / ) is correct?

I think the example in the documentation can be improve. I added the improvement in the doc to this PR as well.

Regardless this example has been in the documentation for 7 years, and maintaining compatibility with this example seems to be simple enough.

What I meant was I haven't found any example of pathspec without starting with /, because it refers to a file path.

modules.d/90dmsquash-live/dmsquash-live-root.sh Outdated Show resolved Hide resolved
This change is required to make the earlier canonical
example work that is mentioned in the documentation:

At the same time, improve the documentation with a more
specific example.
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Apr 1, 2023
@LaszloGombos LaszloGombos requested review from tblume and removed request for danimo June 26, 2023 14:20
@LaszloGombos LaszloGombos removed this from the dracut-060 milestone Aug 5, 2023
@LaszloGombos LaszloGombos removed the bug Our bugs label Aug 5, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Sep 16, 2023
@aafeijoo-suse aafeijoo-suse removed the stale communication is stuck label Sep 18, 2023
@LaszloGombos LaszloGombos reopened this Jan 5, 2024
@github-actions github-actions bot added the man label Jan 5, 2024
Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Mar 13, 2024
@LaszloGombos LaszloGombos added bug Our bugs and removed stale communication is stuck labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Our bugs dmsquash-live Issues related to the dmsquash-live module man modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dracut.cmdline(7): document overlay persistence requirements
3 participants