Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move more testroot dependencies into test-root dracut module #2384

Closed
wants to merge 1 commit into from
Closed

test: move more testroot dependencies into test-root dracut module #2384

wants to merge 1 commit into from

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Jun 10, 2023 •
edited
Loading

Moved test/TEST-01-BASIC/test-init.sh → modules.d/80test-root/test-init.sh .

Changed test-init.sh so that it can call out test specific init and used it in TEST-16.

This should help making steps towards #2383 .

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added modules Issue tracker for all modules test Issues related to testing labels Jun 10, 2023
@Henrik66 Henrik66 force-pushed the testroot branch 11 times, most recently from fd88972 to 3f26f2f Compare June 11, 2023 01:03
LaszloGombos
LaszloGombos approved these changes Jun 11, 2023
View reviewed changes
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Let's convert test 04 as a separate PR. Even if not every test is using test-init.sh from test-root module, this is an improvement.

@LaszloGombos
Copy link
Collaborator

@Henrik66 Can you please rebase this on top of af31df4 - and convert test 18 and test 30 also if reasonable ?

@Henrik66 Henrik66 force-pushed the testroot branch 2 times, most recently from 9bf9b7a to b875eb8 Compare June 17, 2023 16:21
@stale
Copy link

stale bot commented Aug 9, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Aug 9, 2023
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Aug 10, 2023
@LaszloGombos LaszloGombos removed the stale communication is stuck label Aug 10, 2023
@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@Henrik66 Henrik66 closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

@aafeijoo-suse aafeijoo-suse Awaiting requested review from aafeijoo-suse

Assignees
No one assigned
Labels
modules Issue tracker for all modules test Issues related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Henrik66 @LaszloGombos @aafeijoo-suse