Trying to fix #162 #170
Merged
Trying to fix #162 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
pushed a commit
that referenced
this pull request
Oct 20, 2018
PR #170 changed some functions in client.go to use c.GetConfig. The problem is that GetConfig returns empty string if config does not exist. This does not check the config presence on the system, but at least does two separate checks for empty user/email options. It'll still return NoGlobalConfig if options are empty even if the config exists.
driusan
pushed a commit
that referenced
this pull request
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pull request ever! I hope everything is fine.