DnsServerDsc: Replace ConvertTo-HashTableFromObject (#263)

- DnsServerDsc - Replaced the private function `ConvertTo-HashTableFromObject` with the public function `ConvertFrom-DscResourceInstance` (from _DscResource.Common_).
dsccommunity · Jun 29, 2021 · 935e86c · 935e86c
1 parent 4126562
commit 935e86c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 81 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     use the new GitHub issue forms template.
   - Changed the issue template for proposing a new resource to use the new
     GitHub issue forms template.
+  - Replaced the private function `ConvertTo-HashTableFromObject` with the
+    public function `ConvertFrom-DscResourceInstance` (from _DscResource.Common_).
 
 ## [3.0.0] - 2021-05-26
 

diff --git a/source/Classes/001.ResourceBase.ps1 b/source/Classes/001.ResourceBase.ps1
@@ -141,8 +141,8 @@ class ResourceBase
     #>
     hidden [System.Collections.Hashtable[]] Compare()
     {
-        $currentState = $this.Get() | ConvertTo-HashTableFromObject
-        $desiredState = $this | ConvertTo-HashTableFromObject
+        $currentState = $this.Get() | ConvertFrom-DscResourceInstance
+        $desiredState = $this | ConvertFrom-DscResourceInstance
 
         <#
             Remove properties that have $null as the value, and remove read

diff --git a/source/Classes/002.DnsRecordBase.ps1 b/source/Classes/002.DnsRecordBase.ps1
@@ -151,8 +151,8 @@ class DnsRecordBase : ResourcePropertiesBase
         {
             if ($null -ne $existingRecord)
             {
-                $currentState = $this.Get() | ConvertTo-HashTableFromObject
-                $desiredState = $this | ConvertTo-HashTableFromObject
+                $currentState = $this.Get() | ConvertFrom-DscResourceInstance
+                $desiredState = $this | ConvertFrom-DscResourceInstance
 
                 # Remove properties that have $null as the value
                 @($desiredState.Keys) | ForEach-Object -Process {
@@ -196,8 +196,8 @@ class DnsRecordBase : ResourcePropertiesBase
     {
         $isInDesiredState = $true
 
-        $currentState = $this.Get() | ConvertTo-HashTableFromObject
-        $desiredState = $this | ConvertTo-HashTableFromObject
+        $currentState = $this.Get() | ConvertFrom-DscResourceInstance
+        $desiredState = $this | ConvertFrom-DscResourceInstance
 
         if ($this.Ensure -eq 'Present')
         {

diff --git a/source/Private/ConvertTo-HashtableFromObject.ps1 b/source/Private/ConvertTo-HashtableFromObject.ps1
diff --git a/tests/Unit/Private/ConvertTo-HashtableFromObject.tests.ps1 b/tests/Unit/Private/ConvertTo-HashtableFromObject.tests.ps1