Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: xDnsServerSetting: Remove properties DsPollingInterval and DsTombstoneInterval #252

Closed
johlju opened this issue Apr 6, 2021 · 0 comments · Fixed by #257
Closed

BREAKING CHANGE: xDnsServerSetting: Remove properties DsPollingInterval and DsTombstoneInterval #252

johlju opened this issue Apr 6, 2021 · 0 comments · Fixed by #257
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Milestone
v3.0.0

Comments

@johlju
Copy link
Member

johlju commented Apr 6, 2021 •
edited
Loading

Details of the scenario you tried and the problem that is occurring

Suggest removing the properties DsPollingInterval and DsTombstoneInterval from the resource xDnsServerSetting to avoid ping-pong behavior. Instead those should be enforced by the resource DnsServerDsSetting.

Verbose logs showing the problem

n/a

Suggested solution to the issue

See above. Related to issue #251.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

n/a

The operating system the target node is running

Any Windows

Version and build of PowerShell the target node is running

Windows PowerShell

Version of the DSC module that was used

3.0.0 preview
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. on hold The issue or pull request has been put on hold by a maintainer. labels Apr 6, 2021
@johlju johlju added this to the v3.0.0 milestone Apr 6, 2021
@johlju johlju mentioned this issue May 18, 2021
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed on hold The issue or pull request has been put on hold by a maintainer. labels May 18, 2021
johlju added a commit that referenced this issue May 26, 2021
@johlju
DnsServerSetting: Refactor the resource to use cmdlet *-DnsServerSett…
666fca0 
…ing (#257)

- DnsServerSetting
  - BREAKING CHANGE: A few properties that are not supported by any DNS
    Server PowerShell cmdlet was moved to the new resource _DnsServerSettingLegacy_.
  - Changed to use `Get-DnsServerSetting` and `Set-DnsServerSetting`
    ([issue #185](#185)).
  - BREAKING CHANGE: The property `DisableAutoReverseZones` have been renamed
    to `DisableAutoReverseZone`.
  - BREAKING CHANGE: The property `ListenAddresses` have been renamed
    to `ListeningIPAddress`.
  - BREAKING CHANGE: The property `AllowUpdate` was changed to a boolean
    value (`$true` or `$false`) since that is what the cmdlet `Set-DnsServerSetting`
    is expecting (related to [issue #101](#101)).
  - BREAKING CHANGE: The property `EnableDnsSec` was changed to a boolean
    value (`$true` or `$false`) since that is what the cmdlet `Set-DnsServerSetting`
    is expecting.
  - BREAKING CHANGE: The property `ForwardDelegations` was changed to a boolean
    value (`$true` or `$false`) since that is what the cmdlet `Set-DnsServerSetting`
    is expecting.
  - BREAKING CHANGE: The properties `DsPollingInterval` and `DsTombstoneInterval`
    has been removed ([issue #252](#252)).
    Use the resource _DnsServerDsSetting_ to enforce these properties.
- DnsServerSettingLegacy
  - A new resource to manage legacy DNS Server settings that are not supported
    by any DNS Server PowerShell cmdlet.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

DnsServerSetting: Refactor the resource to use cmdlet *-DnsServerSetting johlju/DnsServerDsc
1 participant
@johlju