Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rob-bygrave,
we are currently in the process of updating from ebean 13 to 14 and we encountered a bug, see the test case.
The entity
Contact
has a@ManyToOne
property (without cascadeType)ContactGroup
.In a transaction we store some elements using
DB.insertAll()
. Then we save a contact (without a group), we create a group with a certain id, we save it and then we put the group in the contact.With transaction flush, however, the order in the queue is not correct: contact (with group) is saved first, but group does not yet exist in the DB.
What we discovered during debugging: after
DB.insertAll()
, txn.batchMode = true is set (this was not the case with ebean 13) and during flush the objects contact and group are in the wrong order in the queue.With ebean 13 you have to explicitly call
txn.setBatchMode(true)
for the test to fail.Could you please take a look and help us fix this?
Cheers,
Noemi
@rPraml FYI