Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Batch ordering #3487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nPraml
Copy link
Contributor

@nPraml nPraml commented Oct 2, 2024

Hello @rob-bygrave,

we are currently in the process of updating from ebean 13 to 14 and we encountered a bug, see the test case.

The entity Contact has a @ManyToOne property (without cascadeType) ContactGroup.

In a transaction we store some elements using DB.insertAll(). Then we save a contact (without a group), we create a group with a certain id, we save it and then we put the group in the contact.

With transaction flush, however, the order in the queue is not correct: contact (with group) is saved first, but group does not yet exist in the DB.

What we discovered during debugging: after DB.insertAll(), txn.batchMode = true is set (this was not the case with ebean 13) and during flush the objects contact and group are in the wrong order in the queue.

With ebean 13 you have to explicitly call txn.setBatchMode(true) for the test to fail.

Could you please take a look and help us fix this?

Cheers,
Noemi

@rPraml FYI

@nPraml
Copy link
Contributor Author

nPraml commented Oct 2, 2024

if I modify insertAll on the same way as saveAll:

image

it fixes the test, but the test case fails if I use instead insertAll a trx.setBatchMode(true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant