Enhance the SQL-DataSet-Editor with a search option - see #1584

[speckyspooky]

In the past I programmed lot of SQL-statements which are very long.
Some of my statements have mor like 1.000 lines of code for MS SQL Server.
Also some of my Oracle-statements are very complex and long.

The master development will be done on MS SQL Studio or the SQL-developer.
But in special cases it would be very helpful to have a search option of query text directly on the SQL-DataSetEditor.

The topic is that the standard "Find/Replace"-dialog are not available on the source-viewer-editor which is the core component of the SQL-editor.
To get the search option I would prefer to add directly a search option into the wizard with forward-/backward-serach
and with the standard option of case-sensitive- & whole-word-search.

For this change a created a small PoC for the SQLDataSet-editor

1. Screen, search first text

2. Screen, forward search

3. Screen, forward search end, with message

4. Screen, backward search end, with message

[speckyspooky]

@wimjongman @hvbtup @merks your vote is welcome before I create a PR for this change.

[merks]

@speckyspooky

If it's a helpful feature for you, then I'm sure others will find it helpful too.

BTW, I'm not sure if the new refactor find/replace infrastructure might be useful or reusable for this purpose.

eclipse-platform/eclipse.platform.ui#1192

[speckyspooky]

@merks
Thanks for your vote :o)

Parallel I will show your link to the new version. I saw that the new version is really very new.
So I hope we can to in further steps a kind of improvements to have the first step with the search above
and if the new dialog is usable on this WizardDialog-level we can optimize it.

[Wittmaxi]

@merks the goal is to later provide an interface for all Views to implement so that the overlay can target them. It is alreay possible to implement IFindReplaceTarget and IFindReplaceTargetExtension1..4 in order for the FindReplaceDialog to correctly open and target the view for searching. I strongly vote for using this existing mechanism instead of remaking a new Find/Replace-Mechanism, unless there is no other way. Feel free to reach out in case further questions arise.

[speckyspooky]

@Wittmaxi
Good to hear that all views will get the option for the Find/Replace-Mechanism.
I will not implement a new way, it is a small helper to solve the biggest pain to find query text on large statements.

So if your interface-implementation is done, I would replace my stuff of the simple search with your better version.
Do you have a time schedule for the interface so that we can use the new overlay?

[Wittmaxi]

In order to simplify the transition, your own implementation could look like this:

• Your editor implements IFindReplaceTarget and the required extensions
• Your UI only accesses the editor using these interfaces
  alternatively, you don't even build your own ui but rather just ipen the FindReplaceDialog with your editor as target

There is no concrete timeline and I cannot make any commitments about dates currently. But I will be working on it as soon as the Overlay for the editor is working decently well (in fact, I already have a prototype done which allows the Problems View to use the same overlay!)

[speckyspooky]

Yes, I have extended a new class from the SourceViewer and there I use the IFindReplaceTarget to find the entered search text.
The UI elements are only to control the find options and navigate forward/backward.

So it will be easy to reimplements based on it your overlay.
Let my know when it would be possible to integrate your overlay.

[speckyspooky]

The change is merged to the master branch.