Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The preview does not work anymore: #1901

Closed
wimjongman opened this issue Sep 11, 2024 · 1 comment · Fixed by #1904
Closed

The preview does not work anymore: #1901

wimjongman opened this issue Sep 11, 2024 · 1 comment · Fixed by #1904
Assignees
@wimjongman
Labels
BugFix Change to correct issues
Milestone
4.17

Comments

@wimjongman
Copy link
Contributor 

          The preview does not work anymore:

image

Originally posted by @wimjongman in #1732 (comment)
@wimjongman wimjongman added this to the 4.17 milestone Sep 11, 2024
wimjongman added a commit that referenced this issue Sep 11, 2024
@wimjongman
The preview does not work anymore: #1901
3c462d4 
After switching the default browser to Edge in issues #1736 and #1737
the preview pane was broken because Edge does not like plain filenames.

Fixed:

1. Convert the plain file name to a file URL

This also fixed:

* Ask to save the editor when it is dirty and Preview is
requested. #1902
* 'New Preview Prototype' tab must be called Preview #1903
@wimjongman wimjongman linked a pull request Sep 11, 2024 that will close this issue
The preview does not work anymore: #1901 #1904
Merged
@wimjongman
Copy link
Contributor Author

image

@speckyspooky speckyspooky added the BugFix Change to correct issues label Sep 12, 2024
wimjongman added a commit that referenced this issue Sep 12, 2024
@wimjongman
The preview does not work anymore: #1901
037ccbf 
After switching the default browser to Edge in issues #1736 and #1737
the preview pane was broken because Edge does not like plain filenames.

Fixed:

1. Convert the plain file name to a file URL

This also fixed:

* Ask to save the editor when it is dirty and Preview is
requested. #1902
* 'New Preview Prototype' tab must be called Preview #1903
wimjongman added a commit that referenced this issue Sep 12, 2024
@wimjongman
The preview does not work anymore: #1901 (#1904)
aa849c4 
After switching the default browser to Edge in issues #1736 and #1737
the preview pane was broken because Edge does not like plain filenames.

Fixed:

1. Convert the plain file name to a file URL

This also fixed:

* Ask to save the editor when it is dirty and Preview is
requested. #1902
* 'New Preview Prototype' tab must be called Preview #1903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wimjongman wimjongman

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.17
Development

Successfully merging a pull request may close this issue.

The preview does not work anymore: #1901 eclipse-birt/birt
2 participants
@wimjongman @speckyspooky