Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPlatform:org.eclipse.birt.core.framework.Platform.platform is not in… #1429

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

94satya
Copy link
Contributor

@94satya 94satya commented Sep 21, 2023

IPlatform:org.eclipse.birt.core.framework.Platform.platform is not initializing after OSGi Platform Launcher successful startup #1281 Updated fixed version number with version range for openpdf

…itializing after OSGi PlatformLauncher successful startup eclipse-birt#1281   Updated fixed version number with version range for openpdf
@94satya
Copy link
Contributor Author

94satya commented Sep 21, 2023

@wimjongman @merks @speckyspooky Kindly help review the PR.
This PR is replica of #1423 with correct author.
Once PR will be merged and changes available in the nightly build, We will start our testing ASAP with runtime-OSGI. Thanks

@merks
Copy link
Contributor

merks commented Sep 21, 2023

Funny today I don't see that an ECA check was done. I think there have been recent changes to this infrastructure. I opened this issue to ask what's going on:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3708

Sorry about that!

@94satya
Copy link
Contributor Author

94satya commented Sep 21, 2023

Funny today I don't see that an ECA check was done. I think there have been recent changes to this infrastructure. I opened this issue to ask what's going on:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3708

Sorry about that!

Thanks @merks for help.

@merks
Copy link
Contributor

merks commented Sep 21, 2023

@speckyspooky

If everyone is happy with this, it can be merged...

@94satya
Copy link
Contributor Author

94satya commented Sep 21, 2023

All checks have been passed. Thanks @merks .
Everyone, Please help review or let me know if anything required from my side. Thank you!

@autumnfound
Copy link

Funny today I don't see that an ECA check was done. I think there have been recent changes to this infrastructure. I opened this issue to ask what's going on:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3708
Sorry about that!

Thanks @merks for help.

Poking my head in here, thanks for reporting!! There was a flag on that halted one of our error checking threads, and I've turned it back on, so you shouldn't see this again

@speckyspooky
Copy link
Contributor

Yes, I'm fine with it.

@merks merks merged commit b2c8e2d into eclipse-birt:master Sep 21, 2023
3 checks passed
@94satya
Copy link
Contributor Author

94satya commented Sep 26, 2023

Thank you @speckyspooky @wimjongman @merks for quick review and approval.
Our team started integration with 4.14 nightly build. We will start testing ASAP.
It will be highly appreciated if this get tested by your team as well. This will really help validate the change without any defect(s).
If anything that we should include in our testing kindly let us know .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants