Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the image scaling based on the given dimension (#1750) #1751

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Fix the image scaling based on the given dimension (#1750) #1751

merged 2 commits into from
Jun 23, 2024

Conversation

speckyspooky
Copy link
Contributor

The scaling of the images will be done based on the given dimension if one of dimesnions are missing in relation to the given physical deimensions.

@speckyspooky speckyspooky added the BugFix Change to correct issues label Jun 23, 2024
@speckyspooky speckyspooky added this to the 4.17 milestone Jun 23, 2024
@speckyspooky speckyspooky self-assigned this Jun 23, 2024
@speckyspooky speckyspooky mentioned this pull request Jun 23, 2024
Closed
@speckyspooky
Copy link
Contributor Author

I have added the test results at the issue ticket #1750

@wimjongman wimjongman linked an issue Jun 23, 2024 that may be closed by this pull request
Excel, image scaling is wrong when only one image dimension is set #1750
Closed
wimjongman
wimjongman approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

96.0 is a magic number. For the next iteration please move to a constant.

@speckyspooky
Copy link
Contributor Author

I know the magic of the number. I didn't changed it because was original code.
I will change the number directly with this PR so we have it directly clean up.

@speckyspooky speckyspooky merged commit c553c28 into eclipse-birt:master Jun 23, 2024
3 checks passed
@wimjongman
Copy link
Contributor

I know the magic of the number. I didn't changed it because was original code. I will change the number directly with this PR so we have it directly clean up.

I know the magic of the number. I didn't changed it because was original code. I will change the number directly with this PR so we have it directly clean up.

You're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimjongman wimjongman wimjongman approved these changes

Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.

Excel, image scaling is wrong when only one image dimension is set
2 participants
@speckyspooky @wimjongman