Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *.product files that are not actually used to build products #1777

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 1, 2024

  • Update the all-in-one product configuration to match that of the Platform SDK and the EPP products.

- Update the all-in-one product configuration to match that of the
Platform SDK and the EPP products.
@merks
Copy link
Contributor Author

merks commented Jul 1, 2024

@wimjongman @speckyspooky

Here I am deleting the confusing *.product files that are not actually used to build products. They're actually not used at all.

This way there are only two product files:

image

The one used to build the all-in-one and the one used to build birt-runtime-osgi...

I assume you're okay with this...

@merks merks self-assigned this Jul 1, 2024
@speckyspooky
Copy link
Contributor

Yes, I'm fine with it.

@speckyspooky speckyspooky added this to the 4.17 milestone Jul 1, 2024
@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Jul 1, 2024
@merks merks merged commit 3bd8e16 into eclipse-birt:master Jul 2, 2024
3 checks passed
@merks merks deleted the pr-product-cleanup branch July 2, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants