Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CrosstabXYLayoutEditPolicy to use TableXYLayoutEditPolicy #1826

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Aug 2, 2024

@merks
Copy link
Contributor Author

merks commented Aug 2, 2024

Guys, this fixes the class cast problem but I have no clue if the behavior is correct.

Copy link
Contributor

@speckyspooky speckyspooky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacement is fine. Changed approved.

@speckyspooky
Copy link
Contributor

The general topic is if the new policy won't work correctly then we will have problems with the eclipse layout designer
and we wouldn't be able to create any report. So if we can design new reports with the commen items then it is fine.
Internally it will be used to draw the 2d graphics but this is really deep knowledge of the designer implementation.

The original problem was the change of the policy which was more restrictive on class cast side
so I hope that the new policy provide is only an improvement without special changes. We will see.

@merks merks merged commit 5e17a6f into eclipse-birt:master Aug 2, 2024
3 checks passed
@merks merks deleted the issue-1824 branch August 2, 2024 11:58
@merks
Copy link
Contributor Author

merks commented Aug 2, 2024

I merged so we get a new build the user can test.

@speckyspooky speckyspooky added this to the 4.17 milestone Aug 3, 2024
@speckyspooky speckyspooky added the BugFix Change to correct issues label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants