Ensure that org.apache.axis is in the org.eclipse.birt.engine.runtime

[merks]

• Also add org.eclipse.birt.chart.device.pdf which the only plugin included by org.eclipse.birt.chart.osgi.runtime but not by org.eclipse.birt.engine.runtime.

[merks]

@speckyspooky

I built locally to verify that axis in included with this change:

[merks]

I also added the one bundle specified in only in the chart runtime:

So we could simplify the runtime product to a single feature in the future.

[speckyspooky]

Yes, I see. I will retest directly after the build is done to verify the result.

[merks]

@speckyspooky

Yes, perhaps something else is missing. But we can quickly add anything that might be missing.

[speckyspooky]

Retest is done and failed:

Caused by: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/birt]]
	at org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:419)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:186)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:687)
	... 37 more
Caused by: java.lang.NoClassDefFoundError: javax/xml/soap/SOAPException
	at java.base/java.lang.Class.getDeclaredFields0(Native Method)
	at java.base/java.lang.Class.privateGetDeclaredFields(Class.java:3297)

[speckyspooky]

My test case is very simple and based on the Tomcat installation and try to start the BIRT-viewer as web-applicattion.

So I copy "WebViewerExample" to the tomcat "webapps" folder, rename it to "birt" and try to start my Tomcat.
If the Tomcat is running I check the running applications and finally to start the birt-viewer to create our test reports.

But currently the "birt"-web-application is not starting, "axis" seems to be solved, but "javax.xml.soap" now is missing.

[merks]

I'm surmising this is caused by the ant scripts not copying the right files because the file name has changed.

I see this

$find . -name *apache.axis*
./ReportEngine/platform/plugins/org.apache.axis_1.4.1.v20231107-0937.jar
./war/WEB-INF/lib/org.apache.axis_1.4.1.v20231107-0937.jar
./war/WEB-INF/platform/plugins/org.apache.axis_1.4.1.v20231107-0937.jar
./WebViewerExample/WEB-INF/lib/org.apache.axis_1.4.1.v20231107-0937.jar
./WebViewerExample/WEB-INF/platform/plugins/org.apache.axis_1.4.1.v20231107-0937.jar

$find . -name *soap*
./ReportEngine/platform/plugins/jakarta.xml.soap-api_1.4.2.jar
./war/WEB-INF/platform/plugins/jakarta.xml.soap-api_1.4.2.jar
./WebViewerExample/WEB-INF/platform/plugins/jakarta.xml.soap-api_1.4.2.jar

I think this needs to change:

I'll build locally first to verify this works before creating another PR.

I'll see if I can understand this Tomcat thing to try it myself.

[merks]

Is there a certain version of Tomcat I should install?

[merks]

I guessed it was 9.x.

I got it to this point:

I think another issue with the jar name being different...

[speckyspooky]

I tested Tomcat 9.0.88

[merks]

I got further fixing the ant scripts, but now the clues are less helpful:

I used 9.0.91.

Can you say when was the last time that you tested the web application? The major cleanup with 3 weeks ago; was it tested between today and that point in time? I really rely on the tests to tell me if something is broken.

[merks]

I get the same result using birt-runtime-osgi-4.16.0-202406141054.zip so I don't think I'm really testing properly/correctly.

This looks fine:

Any idea what I might be doing wrong with my testing?

[merks]

Using Java 21 makes no difference.

[speckyspooky]

I have retested our release BIRT 4.16 (Version: birt-runtime-osgi-4.16.0-202406141054),
the result is perfect and our demo reports can be created.

[speckyspooky]

I cannot say when I tested an OSGi-version of BIRT 4.17 the last time with success.
I was triggered based on your dependency change of the "viewer" to test it today.

I must take a look if I have an old 4.17 version at home.

[merks]

Hmm, I forgot to hit enter on my previous observations. The non-OSGI runtime works for me for both 4.16 and 4.17 but the OSGi runtime doesn't work for me for either version.

So hopefully you have good luck with both version for 4.17 when the master build finishes in about 1/2 hour.

[speckyspooky]

I keep you updated after my retest.

[speckyspooky]

Retested with BIRT 4.17 (version: birt-runtime-osgi-4.17.0-202408051540) and it is running,
the demo reports can be created successfully.

Thanks for the dependency changes here to solve the topic!