Only disable the failing rendering tests for windows #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just an initial try just to see if these tests that fail for me in the Windows Maven build actually fail building in the servers on Linux. |
- Support the `system property birt.rendering.tests.enabled` set to `true` to enable the tests even on Windows and enable it in the IDE launchers where the tests function correctly. eclipse-birt#1828
merks
force-pushed
the
pr-rendering-tests
branch
from
4e1e46d
to
8641dd8
Compare
|
This centralizes the condition checking and allows the tests to be easily re-enabled on Windows and in the IDE-launched tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system property birt.rendering.tests.enabledset totrueto enable the tests even on Windows and enable it in the IDE launchers where the tests function correctly.#1828