Bugzilla 490551 UI depends on obsolete eclipse class. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2016 16:58
DefaultContentProvider was removed in Neon causing compile error. Signed-off-by: Carl Thronson <cthronson@actuate.com>
… URL parameter of the viewer servlet. Solution: Use ParameterAccessor.htmlEncode where appropriate in jsp page. Also, no need to apply htmlEncode "early" when obtaining the report title. Also, verify the locale is one of the available locales. In general, ParameterAccessor should validate; but, not do html encoding. The html encoding should take place when the values are used in jsp pages. In general, this strategy has already been followed. The exceptions are for locale/language and report title. Signed-off-by: Carl Thronson <cthronson@actuate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultContentProvider was removed in Neon causing compile error.
This class had only empty methods to satisfy the interface. So, the solution is to simply move these 2 empty methods into the class ReportAdvancedLauncherTab.PluginContentProvider.
Signed-off-by: Carl Thronson cthronson@actuate.com