Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsoleted code in CompilerOptions #2760

Closed
2 tasks
Tracked by #2761
iloveeclipse opened this issue Jul 25, 2024 · 0 comments · Fixed by #2924
Closed
2 tasks
Tracked by #2761

Remove obsoleted code in CompilerOptions #2760

iloveeclipse opened this issue Jul 25, 2024 · 0 comments · Fixed by #2924
Assignees
@iloveeclipse
Labels
compiler Eclipse Java Compiler (ecj) related issues enhancement New feature or request
Milestone
4.34 M1

Comments

@iloveeclipse
Copy link
Member

Found during the review of #2551

  • CompilerOptions.originalComplianceLevel is obsoleted and can be removed + code in TypeConverter using it should be cleaned up.
  • CompilerOptions.originalSourceLevel is obsoleted and can be removed + code in JDT that uses it should be cleaned up
@iloveeclipse iloveeclipse added enhancement New feature or request compiler Eclipse Java Compiler (ecj) related issues labels Jul 25, 2024
@iloveeclipse iloveeclipse mentioned this issue Jul 25, 2024
Open
12 tasks
@iloveeclipse iloveeclipse mentioned this issue Sep 5, 2024
Merged
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.core that referenced this issue Sep 5, 2024
@iloveeclipse
Remove obsoleted code in CompilerOptions
dba0ef7 
Found during the review of eclipse-jdt#2551

- CompilerOptions.originalComplianceLevel is obsoleted and can be
removed + code in TypeConverter using it should be cleaned up.
- CompilerOptions.originalSourceLevel is obsoleted and can be removed +
code in JDT that uses it should be cleaned up

Fixes eclipse-jdt#2760
srikanth-sankaran pushed a commit to iloveeclipse/eclipse.jdt.core that referenced this issue Sep 24, 2024
@iloveeclipse @srikanth-sankaran
Remove obsoleted code in CompilerOptions
e6c9123 
Found during the review of eclipse-jdt#2551

- CompilerOptions.originalComplianceLevel is obsoleted and can be
removed + code in TypeConverter using it should be cleaned up.
- CompilerOptions.originalSourceLevel is obsoleted and can be removed +
code in JDT that uses it should be cleaned up

Fixes eclipse-jdt#2760
@srikanth-sankaran srikanth-sankaran added this to the 4.34 M1 milestone Sep 24, 2024
@iloveeclipse iloveeclipse self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
compiler Eclipse Java Compiler (ecj) related issues enhancement New feature or request
Projects
None yet
Milestone
4.34 M1
Development

Successfully merging a pull request may close this issue.

Remove obsoleted code in CompilerOptions iloveeclipse/eclipse.jdt.core
2 participants
@iloveeclipse @srikanth-sankaran