cortex_a55_smp/gnu: added barrier instruction before setting tx_thread_smp_lock_ready_bit #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_smp_lock_ready_bit in _tx_thread_context_restore() and _tx_thread_system_return() to ensure accesses to shared resources have completed. This ensures that _tx_thread_schedule() reads correct thread data when it sees tx_thread_smp_lock_ready_bit set
|
@microsoft-github-policy-service agree [company="{Cypherbridge Systems}"] |
|
@microsoft-github-policy-service agree |
|
@TiejunMS I note that you have reviewed past pull requests in this repository. Since the status of this PR shows Review Required, could you please tell me what the next step is to request a review? Thank you! |
|
Thanks @phoenix037 ! I just replied in email. |
|
Fixed in #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added barrier instruction before setting tx_thread_smp_lock_ready_bit in _tx_thread_context_restore() and _tx_thread_system_return() to ensure accesses to shared resources have completed. This ensures that _tx_thread_schedule() reads correct thread data when it sees tx_thread_smp_lock_ready_bit set. This update should be relevant for other Cortex-A SMP ports as well. However, the update has been tested only on the Cortex-A55 platform.