Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加Pair类型 #237

Merged
merged 5 commits into from
Jan 8, 2024
Merged

增加Pair类型 #237

merged 5 commits into from
Jan 8, 2024

Conversation

dxyinme
Copy link
Contributor

@dxyinme dxyinme commented Jan 1, 2024

主要参考了 PR #164 和 issue #161 中的评论。
如果对Pair的实现没有异议的话,后续可以根据当前实现继续增加对Triple的支持。

@dxyinme dxyinme changed the title 增加对Pair类型的支持 增加Pair类型 Jan 1, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a23504) 95.85% compared to head (8a50d06) 95.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #237      +/-   ##
==========================================
+ Coverage   95.85%   95.93%   +0.08%     
==========================================
  Files          65       66       +1     
  Lines        3328     3394      +66     
==========================================
+ Hits         3190     3256      +66     
  Misses        106      106              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tuple/pair/pair.go Outdated Show resolved Hide resolved
tuple/pair/pair.go Outdated Show resolved Hide resolved
@dxyinme dxyinme requested a review from flycash January 6, 2024 12:37
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞!

mapx/map.go Outdated Show resolved Hide resolved
tuple/pair/pair.go Outdated Show resolved Hide resolved
@dxyinme dxyinme requested a review from flycash January 7, 2024 10:26
flycash
flycash previously approved these changes Jan 7, 2024
@dxyinme
Copy link
Contributor Author

dxyinme commented Jan 8, 2024

手贱点了update branch :(

@flycash
Copy link
Contributor

flycash commented Jan 8, 2024

测试失败了,看看是啥原因。本地运行一下试试。

@dxyinme
Copy link
Contributor Author

dxyinme commented Jan 8, 2024

测试失败了,看看是啥原因。本地运行一下试试。

已修复,随机出现的bug,起因是map遍历的时候可能不是按照顺序的

@dxyinme dxyinme requested a review from flycash January 8, 2024 12:36
@flycash flycash merged commit 5056d18 into ecodeclub:dev Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants