Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-1 feature parity with Kotlin #1

Merged

Conversation

ori-shem-tov
Copy link

@ori-shem-tov ori-shem-tov commented Mar 25, 2024

  • Added msgpack test
  • Added rawSign and signAlgoTransaction
  • Added more prefixes to check we don't sign other Algorand related stuff
  • Removed prefixes check after decoding

@HashMapsData2Value
Copy link
Collaborator

HashMapsData2Value commented Mar 25, 2024

Great that you added a link to Testnet.

My recommendation:

  • Remove the encodeAddress function and simply import it from algosdk
  • In the signAlgoTransaction test, check that the key encodes to the Algorand address in testnet.
import { decodeUnsignedTransaction, encodeAddress } from "algosdk"

...
...

// (the Pera testnet link comment)         

expect(encodeAddress(key)).toEqual("ML7IGK322ECUJPUDG6THAQ26KBSK4STG4555PCIJOZNUNNLWU3Z3ZFXITA")

After that LGTM

@ori-shem-tov
Copy link
Author

@HashMapsData2Value
added.
please merge as I don't haver sufficient permissions

@HashMapsData2Value HashMapsData2Value merged commit 4319a82 into ehanoc:wallet-api-context Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants