[refactor] Consolidation of auxiliary functions. #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do some cleanup on auxiliary and infra functions: - use filename output functions from common libs - add `Format` based logging functions - remove `Lsp.Io` use to trace, use Fleche Callbacks instead
ejgallego
force-pushed
the
cleanup_lib_log
branch
from
4112a68
to
752c196
Compare
ejgallego
added a commit
that referenced
this pull request
Jun 10, 2024
ejgallego
added a commit
that referenced
this pull request
Jun 10, 2024
ejgallego
added a commit
that referenced
this pull request
Jun 10, 2024
[cleanup] Follow-up for #777 , update a few missing places for new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do some cleanup on auxiliary and infra functions:
Formatbased logging functionsLsp.Iouse to trace, use Fleche Callbacks instead