Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

remove unused es_conf_dir variable #32

Merged
merged 2 commits into from
Jul 22, 2019
Merged

remove unused es_conf_dir variable #32

merged 2 commits into from
Jul 22, 2019

Conversation

astik
Copy link
Contributor

@astik astik commented Jul 21, 2019

As es_conf_dir is not used anywhere in the role, we should remove it.
As it conflict with ansible.elasticsearch variable definition, we need to remove it.

fix #31

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt jmlrt self-requested a review July 22, 2019 10:13
@jmlrt jmlrt added the bug label Jul 22, 2019
@jmlrt
Copy link
Member

jmlrt commented Jul 22, 2019

jenkins test this please

1 similar comment
@jmlrt
Copy link
Member

jmlrt commented Jul 22, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt
Copy link
Member

jmlrt commented Jul 22, 2019

jenkins test this please

@jmlrt jmlrt merged commit 4dc1812 into elastic:master Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ansible-beats conflict with using ansible-elasticsearch at the same time
3 participants