Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

[doc] enhance ansible-beats doc #41

Merged
merged 1 commit into from
Sep 13, 2019
Merged

[doc] enhance ansible-beats doc #41

merged 1 commit into from
Sep 13, 2019

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Sep 13, 2019

Copy link

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found only one kind of typo 😄 othwesise LGTM!

README.md Outdated
- **daemon_args** (*Applicable to version 1.x of beats*): Allows run time params to be passed to beats.
- **logging_conf** (*Defaults to `{"files":{"rotateeverybytes":10485760}}`*): Logging configuration. Should be defined as a map. Map is serialized into logging section of beat config.
- **shipper_conf** (*Applicable to version 1.x of beats*): Shipper configuration. Should be defined as a map . Map is serialized into shipper section of beat config.
- **output_conf** (*Defaults to `{"elasticsearch":{"hosts":["localhost:9200"]}}`): Output configuration. Map is serialized into output section of beat config.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **output_conf** (*Defaults to `{"elasticsearch":{"hosts":["localhost:9200"]}}`): Output configuration. Map is serialized into output section of beat config.
- **output_conf** (*Defaults to `{"elasticsearch":{"hosts":["localhost:9200"]}}`*): Output configuration. Map is serialized into output section of beat config.

- Adapt README file to make it more consistent with [ansible-elasticsearch](https://github.com/elastic/ansible-elasticsearch) README file
- Add more details about how to install different Beats products / version
- Remove some obsolete details
Copy link

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@jmlrt jmlrt merged commit 5ec7143 into elastic:master Sep 13, 2019
@jmlrt jmlrt deleted the doc-version branch September 13, 2019 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants