-
Notifications
You must be signed in to change notification settings - Fork 90
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@jmlrt Hi, can you approve CI ? |
jenkins test this please |
@jmlrt Ok I see why need this feature. But right now, nothing works with ansible :/ |
After some tests, I can confirm that your PR is breaking fix from #34 (only last This is tricky! First solutionRegarding ansible/ansible#48466 (comment), I think that I guess the "Ansible way" to do that would be to have some Example:
I tested it sucessfully in Kitchen tests with playbook variables but not with Second solutionAnother option to make your PR works would be to set a fact based on EDIT: |
…f the role This is related to elastic#51 (comment)
@jmlrt Hi, I added your solution in my PR. |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛴
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency maybe renaming {{ beat }}
to {{ beat_product }}
also in https://github.com/elastic/ansible-beats/pull/52/files#diff-bc46ab85c7ef0bbf4d92e78378717f8cR17-R18 would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛴
jenkins test this please |
Thanks for the PR @ktibi 👍 |
Closes : #47