Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

beat config improvements #59

Merged
merged 4 commits into from
Nov 28, 2019
Merged

beat config improvements #59

merged 4 commits into from
Nov 28, 2019

Conversation

MartinVerges
Copy link
Contributor

In order to offer additional configuration possibilities which we use internally, I have extended the template accordingly by the variable bead_additional_conf. So it is possible to create any beat configuration.

Furthermore our lint test showed some bugs which will be fixed with the second commit.

I would be happy about a merge!

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
0ae347b, 5c8efb6

Please, read and sign the above mentioned agreement if you want to contribute to this project

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
0ae347b, 5c8efb6, 07534e4

Please, read and sign the above mentioned agreement if you want to contribute to this project

@jmlrt
Copy link
Member

jmlrt commented Nov 27, 2019

Hi @MartinVerges,
Any beat configuration can be added via {{ beat_conf }} ansible variable.
Can you provide an example where it would make sense to use {{ beat_additional_conf }} variable instead of {{ beat_conf }}?

@MartinVerges
Copy link
Contributor Author

hi, for example to configure filebeat.modules or setup.kibana or any of all the other options within the reference configuration of the beats.

@jmlrt
Copy link
Member

jmlrt commented Nov 27, 2019

You can already configure filebeat.modules, setup.kibana or any configuration mentioned in filebeat-reference-yml via beat_conf variable.

@MartinVerges
Copy link
Contributor Author

hmm ok, good to know ;)
then the rest of the changes are just fixes for ansible-lint and yamllint.

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Nov 27, 2019

jenkins test this please

@jmlrt jmlrt merged commit d51ef34 into elastic:master Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants