Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Remove beat_install var #6

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Remove beat_install var #6

merged 3 commits into from
Jun 11, 2019

Conversation

levonet
Copy link

@levonet levonet commented May 24, 2018

resolve #5

@levonet
Copy link
Author

levonet commented May 25, 2018

@Crazybus

@karlskewes
Copy link

Good find.
Just came up against this with deploying a change to filebeat.yml and the service not restarting.
There's a third reference to beat_install in both Debian and Rehat files, eg:

register: beat_install

I applied your patch plus removed the third reference above and the filebeat service was successfully restarted on config file change.

$ sudo journalctl -u filebeat | tail -n4
Jul 27 06:24:29 <hostname> systemd[1]: Started filebeat.
Aug 03 10:11:51 <hostname> systemd[1]: Stopping filebeat...
Aug 03 10:11:51 <hostname> systemd[1]: Stopped filebeat.
Aug 03 10:11:51 <hostname> systemd[1]: Started filebeat.
``

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

Crazybus commented Oct 9, 2018

jenkins test this please

@levonet
Copy link
Author

levonet commented Nov 5, 2018

@Crazybus I tried to do this, but I have no idea how to check if service has been restarted.

@jmlrt jmlrt self-requested a review June 11, 2019 18:08
@jmlrt
Copy link
Member

jmlrt commented Jun 11, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmlrt jmlrt merged commit dff01ce into elastic:master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service doesn't restarted if service already ran
5 participants