Fix flaky test Test_runDispatcher/gateway_actions_passed

[andrzej-stencel]

What does this PR do?

Fixes flaky test Test_runDispatcher/gateway_actions_passed by increasing the timeout from 100ms to 200ms.

The flakiness is a result of a 100 miliseconds not always being enough time to dispatch the action in the test environment.

The correct way to fix this issue is to run the assertions in an assert.Eventually with a longer timeout. Unfortunately, a deficiency in the testify testing framework makes it impossible to put the AssertExpectations methods in an assert.Eventually or assert.EventuallyWithT function: stretchr/testify#1414.

The workaround is to increase the context timeout for the gateway actions passed test case. I'm increasing it from 100ms to 200ms.

Why is it important?

Flaky tests are evil!

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in ./changelog/fragments using the changelog tool
• [ ] I have added an integration test or an E2E test

How to test this PR locally

$ go test -v ./internal/pkg/agent/application/ -run Test_runDispatcher

Related issues

• Closes [Flaky Test]: Test_runDispatcher/gateway_actions_passed – Should be empty, but was <insert address here> #4777

[mergify]

This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[blakerouse]

Looks good.

[michel-laterman]

There is discussion on the issue in the description that links to another issue, which links to stretchr/testify#1395; could the approach from this pr be used to make the Eventually type check work?

[andrzej-stencel]

There is discussion on the issue in the description that links to another issue, which links to stretchr/testify#1395; could the approach from this pr be used to make the Eventually type check work?

@michel-laterman I don't know what approach you mean, can you elaborate?

Let me merge this pull request for now, but I'd be happy to continue the conversation to hopefully find a better solution.