This repository has been archived by the owner on Nov 19, 2017. It is now read-only.
[no-unused-vars]: Disallow declaration of variables that are not used in the code. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,8 @@ module.exports = { | |||
| 'no-undef': 2, | |||
| 'no-underscore-dangle': 0, | |||
| 'no-unused-expressions': 0, | |||
| 'no-unused-vars': 0, | |||
| // Disallow declaration of variables that are not used in the code. | |||
| 'no-unused-vars': [2, { vars: 'local', args: 'after-used' }], | |||
There was a problem hiding this comment.
According to the docs, after-used is the default setting, so I don't think we need to set it again.
|
LGTM after that one thing |
cjcenizal
force-pushed
the
7609/improvement/eslint-unused-vars
branch
from
2b3cc7e
to
461321d
Compare
|
What's the advantage of |
|
@Bargs We don't have control over all crappy APIs though. Some dependency could expose something stupid like introduce an iterator function that puts key first, and then we'd be forced to supply a first argument even though we don't want to use it. |
|
Good point @epixa, makes perfect sense. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses elastic/kibana#7609
Relevant rule: http://eslint.org/docs/rules/no-unused-vars
There are 1070 instances of unused vars in Kibana, according to this rule. Let's kill 'em!