Fixes: #2851 : unnecessary pagination

[anishagg17]

Summary

Improved EuiPagination so that it does not appear unnecessarily
Fixes: #2851

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in IE11 and Firefox
• Checked for breaking changes and labeled appropriately
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[chandlerprall]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_2905/

[chandlerprall]

Given #2851 is a bug in the Canvas app and not EUI, this change is only a stylistic one in nature, difference can be see in the docs' first In-Memory Table section (screen shots of difference below).

Adding @cchaos as reviewer.

Existing

https://elastic.github.io/eui/#/tabular-content/tables

Updated

https://eui.elastic.co/pr_2905/#/tabular-content/tables

This PR also introduces a bug when no data is provided, which throws Cannot read property 'length' of undefined at if (pages.length > 1) {. This is reproduced in the In-Memory Table - Selection docs section.

[cchaos]

We had actually talked about this functionality recently and extensively in a different PR #2598 and had made the decision that the pagination controls should still show even if there is only 1 page of results. This means keeping in the arrow buttons, though they would be disabled.

Keeping the arrows (though disabled) indicates to the user what the number 1 represents (paging). Otherwise, there is no context as to what that number indicates. Is it number of results or number of pages.

Since it was found that #2851 was actually a bug in a consuming application, it should have actually been closed. I would opt for not changing the current functionality. Though we definitely appreciate your work on this @anishagg17 , I don't think there is actually a problem to solve here and as @chandlerprall mentioned, this also introduces a bug/error to be thrown.

[anishagg17]

@cchaos I think we should get rid of this

[cchaos]

@anishagg17 Can you explain further?

[anishagg17]

I mean that these icons shouldn't render if there is only a single page

[cchaos]

That is our mobile version of the pagination bar (simply removes the numbers). There's a lot of speculation with how we can make this experience better, however, I don't think just removing them is the right answer. Again, this was discussed in the PR #2598, and we've decided that our current UI display is how we want to handle these situations.

We appreciate your time and feedback on this issue, but I will be closing the issue as we feel we already have the experience we want.