Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiMarkdownEditor #7738

Merged
merged 17 commits into from
May 7, 2024
Merged

[Emotion] Convert EuiMarkdownEditor #7738

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3f5cbcf
Convert tooltips plugin to use inline Emotion
cee-chen May 6, 2024
922eb00
[EuiMarkdownFormat] Migrate all checkbox styles
cee-chen May 6, 2024
ad2597a
[EuiMarkdownFormat] Convert remaining color styles to Emotion
cee-chen May 6, 2024
43eed23
Clean up markdown checkbox styles
cee-chen May 6, 2024
0129b13
Convert footer styles
cee-chen May 7, 2024
5e90afb
Convert toolbar styles
cee-chen May 7, 2024
47873ff
Convert wrapping markdown editor styles
cee-chen May 7, 2024
bcec494
DRY out more component-wide vars
cee-chen May 7, 2024
6613613
Convert textarea styles + convert a few needed form utils to Emotion
cee-chen May 7, 2024
4d2ca45
Convert dropzone styles to Emotion
cee-chen May 7, 2024
715e308
Fix bug where dropzone is still active when editor is in read-only mode
cee-chen May 7, 2024
a77ca5f
Show red invalid line on `errors` prop presence as well
cee-chen May 7, 2024
e159f02
Delete remaining Sass files
cee-chen May 7, 2024
7f96742
[tech debt] Convert all Enzyme tests to RTL
cee-chen May 7, 2024
465ba7f
changelog
cee-chen May 7, 2024
012f1ec
[PR feedback] Fix logical `overflow-y`
cee-chen May 7, 2024
75c375a
[PR feedback] `gap` -> `column-gap`
cee-chen May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/markdown_editor/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@
@import 'markdown_editor_preview';
@import 'markdown_editor_text_area';
@import 'markdown_editor_toolbar';
@import 'plugins/markdown_tooltip';
4 changes: 0 additions & 4 deletions src/components/markdown_editor/plugins/markdown_tooltip.scss
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion src/components/markdown_editor/plugins/markdown_tooltip/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export const tooltipMarkdownRenderer: FunctionComponent<
<strong>{children}</strong>
<EuiIcon
type="questionInCircle"
className="euiMarkdownTooltip__icon"
// This is to offset the tooltip icon, which isn't perfectly centered
css={{ transform: 'translateY(-1px)' }}
mgadewoll marked this conversation as resolved.
Show resolved Hide resolved
/>
</span>
</EuiToolTip>
Expand Down