Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiFormLayout (1/3) #7954

Merged
merged 18 commits into from
Aug 12, 2024

Commits on Aug 8, 2024

  1. Delete now-unused icon number classes/utils

    - entirely replaced by new `getIconAffordanceStyles` util, and CSS variables
    cee-chen committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7101ad2 View commit details
    Browse the repository at this point in the history
  2. Convert .euiFormControlLayout__childrenWrapper to Emotion

    + remove unused euiButtonEmpty styles?? literally not sure what this is doing, button empty does not have borders. probably left over from old theme
    
    + reorder imports
    cee-chen committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bc8380f View commit details
    Browse the repository at this point in the history
  3. Convert compressed & width modifier styles

    - prefer using variables over mixins which contain unnecessary CSS
    cee-chen committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6d89ad9 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    e163e78 View commit details
    Browse the repository at this point in the history
  2. Remove readOnly modifier styles

    - most of the underlying inputs should already be setting their own styles without this component needing to (tested on all components)
    
    - the background color also doesn't need to be set, that's specific to group styles anyway
    
    - I removed the input border color change on readOnly as it doesn't match the default inputs - the border/box-shadow color stays the same for those, so I wanted that here as well
    cee-chen committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5455edf View commit details
    Browse the repository at this point in the history
  3. Convert basic group styles

    - border/background
    
    + extend `euiFormControlDefaultShadow` to allow passing only the box-shadow border and not the background gradient
    cee-chen committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    544c7f1 View commit details
    Browse the repository at this point in the history
  4. Simplify border-radius CSS

    - remove need for compressed/uncompressed CSS by just using `inherit`
    
    - prefer setting a border radius + overflow hidden on the `childrenWrapper` instead of trying to set border radiuses on every possible child
    cee-chen committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b03f81a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Convert append/prepend label styles to Emotion

    - [opinionated change] Add a `<div>` append/prepend wrapper instead of using `React.cloneElement` - less fragile and a better pattern
    
    - use `:not:has` CSS to set padding on the wrapper instead of directly on child elements
    
    - set heights on buttons and text more explicitly
    
    - update form variables to be more specific and remove the unused border var
    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    251bad7 View commit details
    Browse the repository at this point in the history
  2. Remove now-unnecessary EuiFormControlLayout specificity overrides

    + remove extra unnecessary border-radius logic in EuiComboBox - now already handled by EuiFormControlLayout
    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    cf6f74f View commit details
    Browse the repository at this point in the history
  3. Update downstream snapshots

    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    5fc408a View commit details
    Browse the repository at this point in the history
  4. Fix failing test caused by nswapi

    - works correctly in browser but causes test failures
    
    - `:has()` support is apparently flaky, so we need to pin/revert the resolution
    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    d92e40d View commit details
    Browse the repository at this point in the history
  5. Delete Sass files

    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    588aa0b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f755e3c View commit details
    Browse the repository at this point in the history
  7. [storybook] Fix EuiFormControlLayout playground

    - several props (the ones destructured and re-spread to `<EuiFieldText />`) were not correctly updating the actual control
    
    - note: this was already broken in prod
    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    267ea25 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d80e50e View commit details
    Browse the repository at this point in the history
  9. changelog

    cee-chen committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    389935b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    8611ac8 View commit details
    Browse the repository at this point in the history
  2. Revert "Fix failing test caused by nswapi"

    This reverts commit d92e40d.
    cee-chen committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e19f24c View commit details
    Browse the repository at this point in the history