[EuiPageHeaderContent] Improve responsiveness #8044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve/update prop docs - Improve storybook controls to match actual defaults/options - add example `children` - (bonus) memoize styles
- just to make sure I don't regress anything in this PR
- but keep `children` in left side
+ DOM cleanup - remove unnecessary `EuiFlexItem` around `rightSideItems` since we're writing custom flex CSS in any case
- now possible since we've simplified our DOM - no idea why `alignItems === 'top'` needs to be its own condition, it's not doing anything special. remove it since this appears to be defunct code
- slight changes are due to font/typography IIRC, this should mostly show that nothing meaningfully broke for major use cases
cee-chen
force-pushed
the
page-header-responsiveness
branch
from
918c340
to
3a96c32
Compare
mgadewoll
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I really like your approach to adding before/after commits for VRT 👏 🧠
There was a problem hiding this comment.
It's really helpful for me to confirm I'm actually fixing stuff! And also makes before/after screenshots in the PR description a breeze! 😎
packages/eui/src/components/page/page_header/page_header_content.stories.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8034
closes #8039
Fixes involve mostly just re-ordering DOM and playing around flex CSS and container queries.
As always, I recommend following along by commit as some extra cleanup and Storybook/VRT updates happened here.
QA
General checklist
- [ ] Checked in both light and dark modes@defaultif default values are missing)- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)