-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLO] Migrate slo under its very own plugin #176420
Labels
Comments
kdelemme
added
the
Team:obs-ux-management
Observability Management User Experience Team
label
Feb 7, 2024
mgiota
added a commit
that referenced
this issue
Mar 19, 2024
Fixes #176420 ## 🍒 Summary This PR copies the SLO code that was inside the Observability app into its own app under `observability-solution/slo` folder. https://github.com/elastic/kibana/assets/2852703/4f6b8dfb-9612-4d30-ad50-4ee5c55a9c32 ## ✔️ Acceptance criteria - URL of new app: `app/slos` - Design and functionality are not changed. - Git history has been retained for all files in `x-pack/plugins/observability_solution/slo`. - SLO should appear on server less - SLO code inside `observability_solution/observability` code has been removed. A new clean up round might be needed though for possible leftovers. - Burn rate rule is registered within the new slo app - SLO embeddables are moved inside the new slo app - overview - alerts embeddable - error budget burn down - Alerts table configuration registration for slo details page and alerts table embeddable is still done in the observability app. Response Ops team is working on removing the need to register the alert table anyway - Slo app is wrapped into `ApplicationUsageTrackingProvider` which will send slo `Application usage` information tracked by the `slo` appId - Redirect old `app/observability/slos` route to `app/slos` - Rename old `xpack.observability.slo` keys to `xpack.slo` in the translation files ## 🌮 How to test Design and functionality didn't change, so simply navigate to existing slo pages and try to break it - Slo list page - group by - unified search - toggle buttons - actions - Slo creation - try group by as well - Slo detail page - Actions on top - navigate to overview and alerts tabs - Create SLO flyout in Logs Explorer - Create burn rate rules and verify they appear on rules page - Verify SLO alerts appear on Alerts page and slo details page - Embeddables - Through the dashboard app - Using the attach to dashboard action on the slo card item on slo list page and the error budget burn down chart on the slo detail page - SLOs only for platinum users - Permissions - Spaces ## TODO - [x] Move slo stuff from observability folder to new slo plugin - [x] Remove old slo stuff from observability folder - [x] Update references - [x] Fix typescript and eslint errors - [x] Paths - [x] Locators - [x] Burn rate rule registration - [x] Embeddable Alerts table configuration registration - [x] Embeddables - [x] Translations - [x] Verify plugin.ts files contain all registration logic - [x] public - [x] server - [x] Final cleanup for observability folder - [x] Run tests - [x] Application Usage (Telemetry) - [x] Permissions --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad31comp@gmail.com> Co-authored-by: Coen Warmer <coen.warmer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We need to make sure the following migrates properly:
The text was updated successfully, but these errors were encountered: