[Moving] Move Logs Shared folder into /x-pack/observability_solution
#177735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
added
the
release_note:skip
This was referenced Feb 23, 2024
CoenWarmer
added a commit
that referenced
this pull request
Feb 24, 2024
…olution` (#177437) ## Summary This PR is part of the initiative to consolidate Observability plugins into `x-pack/plugins/observability_solution`. This PR is strictly a move and an update in references. This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023. ## Related PRs: - [x] [Move APM ](#177433) - [x] [Move Data Quality](#177456) - [x] [Move Exploratory View](#177440) - [ ] [Move Infra](#177443) - [X] Move Logs Explorer - [ ] [Move Logs Shared](#177735) - [x] [Move Observability AI Assistant](#177427) - [ ] [Move Observability App](#177437) <-- you are here - [x] [Move Observability Onboarding](#177458) - [x] [Move Observability Shared](#177463) - [x] [Move Profiling](#177453) - [x] [Move Synthetics](#177464) - [x] [Move Uptime](#177466) - [x] [Move UX](#177470) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…lugins-logs-shared
…lugins-logs-shared
14 tasks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Mar 4, 2024
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Mar 4, 2024
…olution` (elastic#177437) ## Summary This PR is part of the initiative to consolidate Observability plugins into `x-pack/plugins/observability_solution`. This PR is strictly a move and an update in references. This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023. ## Related PRs: - [x] [Move APM ](elastic#177433) - [x] [Move Data Quality](elastic#177456) - [x] [Move Exploratory View](elastic#177440) - [ ] [Move Infra](elastic#177443) - [X] Move Logs Explorer - [ ] [Move Logs Shared](elastic#177735) - [x] [Move Observability AI Assistant](elastic#177427) - [ ] [Move Observability App](elastic#177437) <-- you are here - [x] [Move Observability Onboarding](elastic#177458) - [x] [Move Observability Shared](elastic#177463) - [x] [Move Profiling](elastic#177453) - [x] [Move Synthetics](elastic#177464) - [x] [Move Uptime](elastic#177466) - [x] [Move UX](elastic#177470) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…olution` (elastic#177437) ## Summary This PR is part of the initiative to consolidate Observability plugins into `x-pack/plugins/observability_solution`. This PR is strictly a move and an update in references. This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023. ## Related PRs: - [x] [Move APM ](elastic#177433) - [x] [Move Data Quality](elastic#177456) - [x] [Move Exploratory View](elastic#177440) - [ ] [Move Infra](elastic#177443) - [X] Move Logs Explorer - [ ] [Move Logs Shared](elastic#177735) - [x] [Move Observability AI Assistant](elastic#177427) - [ ] [Move Observability App](elastic#177437) <-- you are here - [x] [Move Observability Onboarding](elastic#177458) - [x] [Move Observability Shared](elastic#177463) - [x] [Move Profiling](elastic#177453) - [x] [Move Synthetics](elastic#177464) - [x] [Move Uptime](elastic#177466) - [x] [Move UX](elastic#177470) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ioanatia
approved these changes
Mar 5, 2024
kibanamachine
added
v8.14.0
backport:skip
CoenWarmer
added a commit
that referenced
this pull request
Mar 14, 2024
…emetry and i18n ESLint rules for all Obs plugins (#177785) ## Summary This does two things: * Moves to Emotion CSS from .scss files * Enables Telemetry and i18n ESLint rules for all Observability apps ## Why? **Move to Emotion CSS** There were four .scss files total in the 17 Observability plugins. Two of them were empty. The remaining two had one class each. By removing the two empty files and moving to Emotion, we can remove the lines pertaining to .scss files in the CODEOWNERS file. **Enabling Telemetry and i18n ESLint rules for all Observability apps** One of the reasons for consolidating Obs apps into one folder was to create a more consistent development experience across apps in the Observability org. By changing the eslint rule config to enable the [Telemetry](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-telemetry) and [i18n](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-i18n) ESLint rules on all `.ts` and `tsx` files in `observability_solution`, we enable the rule for 5 apps that did not have them enabled before and we ensure that the rule will immediately be enabled on new Observability applications at the moment of creation. ## Related PRs: - [x] [Move APM ](#177433) - [x] [Move Data Quality](#177456) - [x] [Move Exploratory View](#177440) - [x] [Move Infra](#177443) - [X] Move Logs Explorer - [x] [Move Logs Shared](#177735) - [x] [Move Observability AI Assistant](#177427) - [x] [Move Observability App](#177437) - [x] [Move Observability Onboarding](#177458) - [x] [Move Observability Shared](#177463) - [x] [Move Profiling](#177453) - [x] [Move Synthetics](#177464) - [x] [Move Uptime](#177466) - [x] [Move UX](#177470) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the initiative to consolidate Observability plugins into
x-pack/plugins/observability_solution.This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023.
Related PRs: