Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete imports/references to EUI's distributed .css files #194237

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Delete imports/references to EUI's distributed .css files #194237

merged 4 commits into from
Sep 30, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Sep 26, 2024 •
edited by kibanamachine
Loading

Summary

Trying #194082 again, this time wholly deleting kbn-ui-shared-deps-npm.v8.light/dark.css as well 🤞

Original PR description:

These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static .css files (although .scss src files will still remain exported for the near future).

@cee-chen
Delete direct imports of EUI's distributed .css files
bfae2aa 
- no longer contains any meaningful or used CSS as of the finished Emotion migration
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Sep 26, 2024
@cee-chen
Remove kbn-ui-shared-deps-npm.v8.light/dark completely
c1d98bb 
- does not contain any CSS other than EUI's, and confirmed by KibanaOps as not likely contain any in the future
@cee-chen cee-chen marked this pull request as ready for review September 27, 2024 14:27
@cee-chen cee-chen requested review from a team as code owners September 27, 2024 14:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

nreese
nreese approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

elena-shostak
elena-shostak approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@elena-shostak elena-shostak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM!

@jbudz
Copy link
Member

jbudz commented Sep 27, 2024

Mind if we add one (any) of the project deploy labels? It's where we caught the issue last time, I'll do a validation run on it.

@cee-chen
Copy link
Member Author

cee-chen commented Sep 27, 2024 via email

afharo
afharo approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM depending on @jbudz's tests.

Q: I overheard that we'll be trying out a new theme soon. Since we are removing the themeVersion, how are we planning to control a rollback? or maybe it won't be offered?

@jbudz jbudz added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Sep 27, 2024
@jbudz
Copy link
Member

jbudz commented Sep 27, 2024

buildkite test this

@cee-chen cee-chen enabled auto-merge (squash) September 30, 2024 17:06
@cee-chen cee-chen mentioned this pull request Sep 30, 2024
Merged
2 tasks
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 30, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #110 / transform basic license transform - creation - runtime mappings & saved search creation with runtime mappings batch transform with pivot configurations and runtime mappings navigates through the wizard and sets all needed fields

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 129.6KB 125.9KB -3.8KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -4.0B
total -3.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 866adf3 into elastic:main Sep 30, 2024
26 checks passed
@cee-chen cee-chen deleted the eui/delete-css-file branch September 30, 2024 18:37
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11112129346

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
@cee-chen
Delete imports/references to EUI's distributed .css files (elastic#…
ae70cac 
…194237)

## Summary

Trying elastic#194082 again, this time wholly deleting
`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞

Original PR description:

> These files no longer contain any meaningful CSS used within Kibana as
of EUI's completed Emotion migration, and can be safely removed. EUI
will shortly no longer distribute these static `.css` files (although
`.scss` src files will still remain exported for the near future).

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 866adf3)
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2024
@kibanamachine @cee-chen
[8.x] Delete imports/references to EUI&#x27;s distributed &#x60;.css&…
9079fb6 
…#x60; files (#194237) (#194474)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Delete imports/references to EUI&#x27;s distributed &#x60;.css&#x60;
files (#194237)](#194237)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T18:37:47Z","message":"Delete
imports/references to EUI's distributed `.css` files (#194237)\n\n##
Summary\r\n\r\nTrying #194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-elasticsearch","v8.16.0","backport:version"],"title":"Delete
imports/references to EUI's distributed `.css`
files","number":194237,"url":"https://github.com/elastic/kibana/pull/194237","mergeCommit":{"message":"Delete
imports/references to EUI's distributed `.css` files (#194237)\n\n##
Summary\r\n\r\nTrying #194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194237","number":194237,"mergeCommit":{"message":"Delete
imports/references to EUI's distributed `.css` files (#194237)\n\n##
Summary\r\n\r\nTrying #194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
@afharo afharo mentioned this pull request Oct 1, 2024
Draft
10 tasks
neptunian pushed a commit to neptunian/kibana that referenced this pull request Oct 1, 2024
@kibanamachine @cee-chen @neptunian
[8.x] Delete imports/references to EUI&#x27;s distributed &#x60;.css&…
c602fa4 
…#x60; files (elastic#194237) (elastic#194474)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Delete imports/references to EUI&#x27;s distributed &#x60;.css&#x60;
files (elastic#194237)](elastic#194237)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T18:37:47Z","message":"Delete
imports/references to EUI's distributed `.css` files (elastic#194237)\n\n##
Summary\r\n\r\nTrying elastic#194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-elasticsearch","v8.16.0","backport:version"],"title":"Delete
imports/references to EUI's distributed `.css`
files","number":194237,"url":"https://github.com/elastic/kibana/pull/194237","mergeCommit":{"message":"Delete
imports/references to EUI's distributed `.css` files (elastic#194237)\n\n##
Summary\r\n\r\nTrying elastic#194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194237","number":194237,"mergeCommit":{"message":"Delete
imports/references to EUI's distributed `.css` files (elastic#194237)\n\n##
Summary\r\n\r\nTrying elastic#194082 again, this time wholly
deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well
🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer
contain any meaningful CSS used within Kibana as\r\nof EUI's completed
Emotion migration, and can be safely removed. EUI\r\nwill shortly no
longer distribute these static `.css` files (although\r\n`.scss` src
files will still remain exported for the near
future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Oct 2, 2024
@cee-chen @kibanamachine @seanrathier
Delete imports/references to EUI's distributed .css files (elastic#…
07bb0ca 
…194237)

## Summary

Trying elastic#194082 again, this time wholly deleting
`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞

Original PR description: 

> These files no longer contain any meaningful CSS used within Kibana as
of EUI's completed Emotion migration, and can be safely removed. EUI
will shortly no longer distribute these static `.css` files (although
`.scss` src files will still remain exported for the near future).

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@jbudz jbudz jbudz approved these changes

@afharo afharo afharo approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project EUI release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cee-chen @elasticmachine @jbudz @kibana-ci @kibanamachine @nreese @afharo @elena-shostak