[state] don't make extra $location.replace() calls #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple of questions;
|
Yeah, the fix for that (#8022) caused the bug
It just reflects the current value of the
The tests pass locally, and this is specifically fixing the bug caused by #8022 |
| return null; | ||
| } | ||
|
|
||
| if (this.isHashingEnabled()) { |
There was a problem hiding this comment.
Because there are so many conditionals and early-exits in this method, I think it's worth adding a comment describing the state of the app in which this condition is reached:
if (this.isHashingEnabled()) {
// If Kibana has been loaded for the first time with RISON states URL, and the user has has hashed states
// enabled, then update the URL to show the hashed states instead of the RISON states.
}
|
1 comment, then LGTM! |
|
i agree with CJ, else LGTM |
Issue: In order to ensure BWC in the new state-hashing changes, rison encoded query string parameters are automatically converted into hashes and placed back into the URL via `$location.search().replace()`. This ensures that extra history entries don't get created, but this is still happening when hashing is disabled (which is now the default). This causes every state-caused history change to become a replacement, which mutilates the history stack. Fix: Added a `#isHashingEnabled()` method to the state objects that is called before trying to convert rison encoded query string states and replacing them in the URL.
spalger
force-pushed
the
fix/stateReplacement
branch
from
2db123f
to
9c52032
Compare
|
@spalger Since the url state management flag was released in 4.6.4 as well, think we should backport this to 4.6, or is this a non-issue prior to 5.0? |
|
Yeah, I'll backport this to 4.6 |
elastic-jasper
added a commit
that referenced
this pull request
Jan 19, 2017
Backports PR #8179 **Commit 1:** [state] don't make extra $location.replace() calls Issue: In order to ensure BWC in the new state-hashing changes, rison encoded query string parameters are automatically converted into hashes and placed back into the URL via `$location.search().replace()`. This ensures that extra history entries don't get created, but this is still happening when hashing is disabled (which is now the default). This causes every state-caused history change to become a replacement, which mutilates the history stack. Fix: Added a `#isHashingEnabled()` method to the state objects that is called before trying to convert rison encoded query string states and replacing them in the URL. * Original sha: 9c52032 * Authored by spalger <email@spalger.com> on 2016-09-07T17:29:12Z
spalger
pushed a commit
that referenced
this pull request
Feb 1, 2017
Backports PR #8179 **Commit 1:** [state] don't make extra $location.replace() calls Issue: In order to ensure BWC in the new state-hashing changes, rison encoded query string parameters are automatically converted into hashes and placed back into the URL via `$location.search().replace()`. This ensures that extra history entries don't get created, but this is still happening when hashing is disabled (which is now the default). This causes every state-caused history change to become a replacement, which mutilates the history stack. Fix: Added a `#isHashingEnabled()` method to the state objects that is called before trying to convert rison encoded query string states and replacing them in the URL. * Original sha: 9c52032 * Authored by spalger <email@spalger.com> on 2016-09-07T17:29:12Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[state] don't make extra $location.replace() calls Former-commit-id: d2aff6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In order to ensure BWC in the new state-hashing changes, rison encoded query string parameters are automatically converted into hashes and placed back into the URL via
$location.search().replace(). This ensures that extra history entries don't get created, but this is still happening when hashing is disabled (which is now the default). This causes every state-caused history change to become a replacement, which mutilates the history stack.Fix:
Added a
#isHashingEnabled()method to the state objects that is called before trying to convert rison encoded query string states and replacing them in the URL.