Support Fleet output Logstash ssl fields #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
daemitus
commented
Nov 30, 2023
daemitus
commented
Nov 30, 2023
|
eh hold on. certificate_authorities isnt working. |
tobio
previously approved these changes
Dec 1, 2023
|
@daemitus are you able to take a look at the test failures here? |
|
Now segfaults. I'll have to run the test locally for this one. |
tobio
reviewed
Dec 6, 2023
|
wish I had seen |
tobio
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #497
Add in the 3 ssl fields to the logstash-type fleet output resource.
I've run it on my dev stack a few times and I'm happy with most everything except the anonymous nested SSL struct that gets generated. Can that get yanked out?