Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for deploying data views to non-default spaces. #559

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Conversation

tobio
Copy link
Member

@tobio tobio commented Feb 5, 2024

Fixes #530
Related to elastic/kibana#176197

This PR fixes a couple of issues:

  • Actually support defining a DV in a non-default space
  • Fixes up a bug when defining a DV with namespaces, in the case the API ignores the Space the DV is defined in. This PR just ensures that the declared space is included in the list of namespaces
  • Adds support for resource imports.

@tobio tobio self-assigned this Feb 5, 2024
@@ -13,6 +13,7 @@
- Fix issue when setting `override` in `elasticstack_kibana_data_view` resource ([#550](https://github.com/elastic/terraform-provider-elasticstack/pull/550))
- Fixup typos in `elasticstack_elasticsearch_transform` and `elasticstack_kibana_security_role` docs ([#551](https://github.com/elastic/terraform-provider-elasticstack/pull/551))
- Fix issue when setting `field_attrs` in `elasticstack_kibana_data_view` resource ([#552](https://github.com/elastic/terraform-provider-elasticstack/pull/552))
- Fixup support for managing `elasticstack_kibana_data_view` resources in non-default spaces ([#559](https://github.com/elastic/terraform-provider-elasticstack/pull/559))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it mention defect #530 too?

Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit 0da5110 into main Feb 6, 2024
29 checks passed
@tobio tobio deleted the dv-spaces branch February 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] elasticstack_kibana_data_view can't handle different space IDs
2 participants