Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ApiKey instead of Bearer #576

Merged
merged 2 commits into from
Feb 29, 2024
Merged

feat: use ApiKey instead of Bearer #576

merged 2 commits into from
Feb 29, 2024

Conversation

xeivieni
Copy link
Contributor

Copy link

cla-checker-service bot commented Feb 28, 2024

💚 CLA has been signed

@xeivieni xeivieni closed this Feb 28, 2024
@xeivieni xeivieni reopened this Feb 28, 2024
@xeivieni
Copy link
Contributor Author

@tobio could you please look at this ?

It fixes bug #415

@tobio
Copy link
Member

tobio commented Feb 29, 2024

FWIW the correct link for the Kibana API is here. It's lacking some detail on how to use API key auth though. The conclusion is however still correct, i.e we need to use the ApiKey prefix, rather than Bearer.

The docs linked to in the original issue are for the ESS (Cloud) API which currently uses a different API key to Kibana/Elasticsearch.

@tobio
Copy link
Member

tobio commented Feb 29, 2024

@xeivieni thanks for taking the time to fix this issue. Are you able to add an item to the CHANGELOG for this one?

tobio
tobio previously approved these changes Feb 29, 2024
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, we just need a changelog entry prior to merging.

@xeivieni
Copy link
Contributor Author

@tobio thanks for the review, I add the information in the CHANGELOG as requested

@tobio tobio merged commit 4e64d6b into elastic:main Feb 29, 2024
15 checks passed
@tobio
Copy link
Member

tobio commented Feb 29, 2024

Love it @xeivieni tyvm!

@xeivieni
Copy link
Contributor Author

Do you think it can be released today ?

@tobio
Copy link
Member

tobio commented Mar 13, 2024

@xeivieni this has been released today as part of 0.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants