remove space_id parameter from private locations #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
private location is agnostic to kibana spaces. The field space_id was previously incorrectly used, because its value was a `namespace` of agent policy (data stream). This PR removes the field. As there is no way to update a private location via API (only replace), there is no benefit to introduce `namespace` field for private locations.
tobio
reviewed
Sep 9, 2024
|
Thanks, @tobio ,
Yes, that is correct. |
biscout42
changed the title
tobio
approved these changes
Sep 9, 2024
tobio
added a commit
to jdesnoes/terraform-provider-elasticstack
that referenced
this pull request
Sep 11, 2024
…-data-source * origin/main: (23 commits) Migrate index resource to plugin framework (elastic#698) Remove duplicate code (elastic#761) fix(deps): update module github.com/hashicorp/terraform-plugin-framework-jsontypes to v0.2.0 (elastic#760) fix(deps): update module github.com/golangci/golangci-lint to v1.61.0 (elastic#759) Add support for the`frequency` field in the Create Rule API (elastic#753) Prevent a provider panic when the referenced snapshot repo does not exist (elastic#758) remove space_id paramter from private locations (elastic#733) chore(deps): update dependency go to v1.23.1 (elastic#755) chore(deps): update docker.elastic.co/elasticsearch/elasticsearch docker tag to v8.15.1 (elastic#756) chore(deps): update golang:latest docker digest to 4a3c2bc (elastic#754) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v8.15.1 (elastic#757) Fixup error handling during saved object imports (elastic#738) fix(deps): update module github.com/goreleaser/goreleaser to v2 (elastic#748) chore(deps): update golangci/golangci-lint-action action to v6 (elastic#746) chore(deps): update codecov/codecov-action action to v4 (elastic#745) fix(deps): update module github.com/go-resty/resty/v2 to v2.14.0 (elastic#741) chore(deps): update actions/setup-go action to v5 (elastic#744) chore(deps): update actions/checkout action to v4 (elastic#743) fix(deps): update module github.com/deepmap/oapi-codegen/v2 to v2.3.0 (elastic#740) chore(deps): update dependency go to v1.23.0 (elastic#739) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726