Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapcraft core22 and core24 support [#8548] #8549

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

filfreire
Copy link
Contributor

@filfreire filfreire commented Sep 30, 2024

Closes #8548

Not tested yet

cc @mmaietta

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 2b5c6ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@filfreire filfreire changed the title fix/8548 fix: snapcraft core22 and core24 support [#8548] Sep 30, 2024
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 2b5c6ed
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66fc15aabfca460008cbb623
😎 Deploy Preview https://deploy-preview-8549--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

Thanks for your contribution! We'll also want a new unit test for core24.

You can probably just copy-paste this test and update the snap.base value

test.ifDevOrLinuxCi(
"base option",
app({
targets: snapTarget,
config: {
productName: "Sep",
snap: {
base: "core22",
},
},
effectiveOptionComputed: async ({ snap }) => {
expect(snap).toMatchSnapshot()
expect(snap.base).toBe("core22")
return true
},
})
)

Why is this considered a major semver bump though? Seems more like a minor or even patch semver for fixing core22 and a new feature for core24 as I don't see any breaking API changes

@filfreire
Copy link
Contributor Author

@mmaietta added a test for base core24 and edited the changeset to something lower than major

@filfreire filfreire marked this pull request as ready for review October 1, 2024 09:22
@mmaietta
Copy link
Collaborator

mmaietta commented Oct 1, 2024

@filfreire is this tested yet since it's marked ready for review? If so, please update the PR description accordingly when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix support for snapcraft core22 and core24
2 participants