-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: snapcraft core22 and core24 support [#8548] #8549
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2b5c6ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for your contribution! We'll also want a new unit test for core24. You can probably just copy-paste this test and update the electron-builder/test/src/linux/snapTest.ts Lines 314 to 330 in fc3a78e
Why is this considered a |
@mmaietta added a test for base |
@filfreire is this tested yet since it's marked ready for review? If so, please update the PR description accordingly when you have a chance. |
Closes #8548
Not tested yet
cc @mmaietta