Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App crashing when a message is sent at the same time one is received #1125

Closed
jmartinesp opened this issue Aug 23, 2023 · 1 comment · Fixed by #1126
Closed

App crashing when a message is sent at the same time one is received #1125

jmartinesp opened this issue Aug 23, 2023 · 1 comment · Fixed by #1126
Assignees
@jmartinesp
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems z-Crash

Comments

@jmartinesp
Copy link
Member

jmartinesp commented Aug 23, 2023 •
edited
Loading

Steps to reproduce

I couldn't reproduce it myself, but we have on rageshake that states:

yeah, it seems that if I happen to send a message at the same time that someone else in room sends theirs (a bit of animations for those messages appears) app will crash.

The logs point out to a force unwrap of eventId in RoomMessageFactory. Taking a look at the Rust SDK, this can happen when a local message has an echo but it's not sent yet.

Outcome

What did you expect?

The app to ignore the message and keep working.

What happened instead?

The app crashed.

Your phone model

Pixel 3

Operating system version

Android 12

Application version and app store

Element X dbg/0.1.4

Homeserver

rom4nik.pl

Will you send logs?

Yes

Are you willing to provide a PR?

Yes
@jmartinesp jmartinesp added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow z-Crash labels Aug 23, 2023
@jmartinesp jmartinesp self-assigned this Aug 23, 2023
@jmartinesp jmartinesp mentioned this issue Aug 23, 2023
Merged
@jmartinesp jmartinesp added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 23, 2023
@bmarty
Copy link
Member

bmarty commented Aug 24, 2023

(FTR: also reported by Sentry: https://sentry.tools.element.io/organizations/element/issues/84352/?project=59)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems z-Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When event has no id, just cancel parsing the latest room message element-hq/element-x-android
2 participants
@jmartinesp @bmarty