New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When event has no id, just cancel parsing the latest room message #1126

Merged

jmartinesp merged 1 commit into develop from fix/jme/1125-app-crashing-with-null-event-id

Aug 23, 2023

Member

jmartinesp commented Aug 23, 2023 •

edited

Loading

Fixes #1125.


          When event has no id, just cancel parsing the latest room message for…

ace327b

… a room

jmartinesp requested a review from a team as a code owner

August 23, 2023 12:28

jmartinesp requested review from julioromano and removed request for a team

August 23, 2023 12:28

julioromano approved these changes

View reviewed changes

jmartinesp enabled auto-merge (squash)

August 23, 2023 12:38

Contributor

github-actions bot commented Aug 23, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6pVqNm

codecov bot commented Aug 23, 2023 •

edited

Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (6822e6d) 57.12% compared to head (ace327b) 57.12%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1126   +/-   ##
========================================
  Coverage    57.12%   57.12%           
========================================
  Files         1021     1021           
  Lines        26131    26131           
  Branches      5288     5289    +1     
========================================
  Hits         14927    14927           
  Misses        8896     8896           
  Partials      2308     2308

Files Changed	Coverage Δ
...ies/matrix/impl/room/message/RoomMessageFactory.kt	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

jmartinesp merged commit 7eb1f1c into develop

14 of 16 checks passed

jmartinesp deleted the fix/jme/1125-app-crashing-with-null-event-id branch

August 23, 2023 12:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet