Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Dms use other member color. #3058

Merged
merged 19 commits into from
Jun 21, 2024
Merged

Let Dms use other member color. #3058

merged 19 commits into from
Jun 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 20, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure that a DM will use the same color that the other user color.

Preparatory work for a wider rendering of heroes. Note: the rendering of multiple heroes is currently disabled by ac6e56f.

Motivation and context

Closes #1538

Screenshots / GIFs

For the user:

image

Here is how it is rendered in the room list:

Before After
image Screenshot 2024-06-20 at 14 37 38

Tests

  • Observer the default color of DM room.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 20, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9sshsu

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 20, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 20, 2024
modifier = Modifier
.size(70.dp)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is actually fixing a rendering issue, see the recorded screenshot. The Avatar was not rendered correctly.

@bmarty bmarty marked this pull request as ready for review June 20, 2024 13:58
@bmarty bmarty requested a review from a team as a code owner June 20, 2024 13:58
@bmarty bmarty requested review from ganfra and removed request for a team June 20, 2024 13:58
@bmarty bmarty changed the title Dm color uses other member colors. Let Dms use other member color. Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 85.54217% with 24 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (4317b80) to head (3ce4af9).
Report is 4 commits behind head on develop.

Files Patch % Lines
.../designsystem/components/avatar/CompositeAvatar.kt 77.35% 6 Missing and 6 partials ⚠️
...list/impl/datasource/RoomListRoomSummaryFactory.kt 83.33% 2 Missing and 2 partials ⚠️
...cations/edit/EditDefaultNotificationSettingView.kt 60.00% 1 Missing and 1 partial ⚠️
...libraries/designsystem/components/avatar/Avatar.kt 81.81% 0 Missing and 2 partials ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt 80.00% 1 Missing ⚠️
...ages/impl/mentions/MentionSuggestionsPickerView.kt 83.33% 0 Missing and 1 partial ⚠️
...oid/libraries/matrix/ui/components/SelectedRoom.kt 80.00% 1 Missing ⚠️
...ndroid/libraries/roomselect/impl/RoomSelectView.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3058      +/-   ##
===========================================
+ Coverage    75.91%   75.92%   +0.01%     
===========================================
  Files         1628     1631       +3     
  Lines        38409    38504      +95     
  Branches      7421     7437      +16     
===========================================
+ Hits         29158    29235      +77     
- Misses        5375     5387      +12     
- Partials      3876     3882       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 20, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 20, 2024
Copy link

sonarcloud bot commented Jun 20, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@bmarty bmarty merged commit 981dad7 into develop Jun 21, 2024
22 of 23 checks passed
@bmarty bmarty deleted the feature/bma/dmColor branch June 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM and user color are different
2 participants