-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stickers display text on room summary #3221
Conversation
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
ed9f5a9
to
910ff61
Compare
I've created #3225 to try to fix the CI issues you're seeing. EX Enterprise setup apparently broke it. |
@surakin that... didn't go well. Maybe you'll need to rebase |
58d33b0
to
ea0ae4c
Compare
Agh, the wrong code got merged... That's what I get for playing with different remotes and having 2 opened PRs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that's better. Let's see if new screenshots are needed, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a test case needs to be fixed before it's merged. It would also be nice to check if no screenshot updates are needed.
38b570b
to
4abd82b
Compare
I ran the record screenshot actions and it didn't find any changes 🤔 |
719194e
to
fdc2751
Compare
...tlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
fdc2751
to
f2b074e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3221 +/- ##
===========================================
- Coverage 76.13% 76.12% -0.02%
===========================================
Files 1645 1645
Lines 38839 38839
Branches 7530 7530
===========================================
- Hits 29570 29566 -4
- Misses 5361 5362 +1
- Partials 3908 3911 +3 ☔ View full report in Codecov by Sentry. |
Content
Tweak how stickers are displayed in the room summary
Motivation and context
After this change matrix-org/matrix-rust-sdk#3715 stickers will show up in the room summary but only displaying the content body, which can be interpreted as a file name or as a sticker description, but in both cases it can look like a normal message (Images appear as 'Image').
Screenshots / GIFs
Before
After
Tests
Tested devices
Checklist