Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate send failure verification #3485

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 18, 2024

Content

Fix crash when resolving verification send failure.
Also show a clearer content when unverified device is from you.

Motivation and context

Closes #3484

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Change For updates to an existing feature label Sep 18, 2024
@ganfra ganfra changed the title Feature/fga/iterate send failure verification Iterate send failure verification Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/H3ELX8

@ganfra ganfra force-pushed the feature/fga/iterate_send_failure_verification branch from 5d0ce52 to 5240555 Compare September 18, 2024 09:31
@ganfra ganfra marked this pull request as ready for review September 18, 2024 09:34
@ganfra ganfra requested a review from a team as a code owner September 18, 2024 09:34
@ganfra ganfra requested review from bmarty and removed request for a team September 18, 2024 09:34
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@ganfra ganfra merged commit 4f86909 into develop Sep 18, 2024
28 checks passed
@ganfra ganfra deleted the feature/fga/iterate_send_failure_verification branch September 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] A clearer message to the user when sending fails due to their own unverified devices
2 participants