Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extended span to traceutils #28

Merged
merged 4 commits into from
Nov 2, 2023
Merged

add extended span to traceutils #28

merged 4 commits into from
Nov 2, 2023

Conversation

jslching
Copy link
Collaborator

@jslching jslching commented Nov 1, 2023

No description provided.

@jslching jslching self-assigned this Nov 1, 2023
Copy link
Collaborator

@lukseven lukseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would make the suggested changes for simplification.

util/traceutil/trace/span.go Outdated Show resolved Hide resolved
util/traceutil/trace/span.go Outdated Show resolved Hide resolved
util/traceutil/trace/span.go Outdated Show resolved Hide resolved
lukseven
lukseven previously approved these changes Nov 2, 2023
@jslching jslching merged commit 290c294 into master Nov 2, 2023
1 check passed
@jslching jslching deleted the trace-span-extended branch November 2, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants