Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable server extensions as both Notebook/Jupyter Server extensions #1476

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

lresende
Copy link
Member

@lresende lresende commented Mar 25, 2021

The Elyra image was working fine in JupyterHub/Binder until recently, which seems to have introduced a regression where Jupyter Server extensions are not being recognized. This has been reported/workarounded in a few JupyterLab extensions running on Hub/Binder environments (e.g. jupyterlab/jupyterlab-git#863) and we are following the same approach, which we used to have in the past as well.

I also looked into Hub/Binder to see if I could find the culprit commit, but I am not very familiar with where things are handled in Binder and didn't have much success and decided to stop.

Fixes #1474

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Mar 25, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende changed the title Fix jupyterhub support Enable server extensions as both Notebook/Jupyter Server extensions Mar 25, 2021
@lresende lresende modified the milestones: 2.1.1, 2.2.0 Mar 25, 2021
@lresende
Copy link
Member Author

Tested this in both binder and regular local docker env and both are working with these changes.

@kevin-bates
Copy link
Member

kevin-bates commented Mar 25, 2021

Could you please add an explanation as to why we need duplicated configurations for NotebookApp? This version of Elyra only uses Jupyter Server.

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, it looks the same as when I did this on nbdime. I have not tested local though

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good - thanks for tackling this!

@lresende lresende merged this pull request into elyra-ai:master Mar 25, 2021
@lresende lresende deleted the fix-jupyterhub-support branch March 25, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elyra installation on Jupyterhub: "Error contacting server - Endpoint elyra/namespace not found"
3 participants