-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable server extensions as both Notebook/Jupyter Server extensions #1476
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Tested this in both binder and regular local docker env and both are working with these changes. |
Could you please add an explanation as to why we need duplicated configurations for NotebookApp? This version of Elyra only uses Jupyter Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, it looks the same as when I did this on nbdime. I have not tested local though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good - thanks for tackling this!
9ea827a
to
3c1840a
Compare
The Elyra image was working fine in JupyterHub/Binder until recently, which seems to have introduced a regression where
Jupyter Server
extensions are not being recognized. This has been reported/workarounded in a few JupyterLab extensions running on Hub/Binder environments (e.g. jupyterlab/jupyterlab-git#863) and we are following the same approach, which we used to have in the past as well.I also looked into Hub/Binder to see if I could find the culprit commit, but I am not very familiar with where things are handled in Binder and didn't have much success and decided to stop.
Fixes #1474
Developer's Certificate of Origin 1.1